From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: kernel list <linux-kernel@vger.kernel.org>,
linux-ide@vger.kernel.org, David Miller <davem@davemloft.net>
Subject: Re: [PATCH] au1xxx-ide.c: ioremap() returns a void __iomem *
Date: Sun, 13 Dec 2009 01:54:08 +0300 [thread overview]
Message-ID: <4B241F10.7050706@ru.mvista.com> (raw)
In-Reply-To: <BD79186B4FD85F4B8E60E381CAEE190901FB10C2@mi8nycmail19.Mi8.com>
Hello.
H Hartley Sweeten wrote:
> The ioremap return value is an __iomem *, not an integer. Update the
> private structure to reflect this. While here, remove the typedef
> for _auide_hwif and just use struct auide_hwif instead as recommended
> by Documentation/CodingStyle.
>
> auide_setup_ports() still needs to cast the regbase back to an integer
> to correctly setup the io_ports_array.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: David Miller <davem@davemloft.net>
>
> ---
>
> diff --git a/Documentation/mips/AU1xxx_IDE.README b/Documentation/mips/AU1xxx_IDE.README
> index 8ace35e..37c6c34 100644
> --- a/Documentation/mips/AU1xxx_IDE.README
> +++ b/Documentation/mips/AU1xxx_IDE.README
> @@ -45,7 +45,7 @@ FILES, CONFIGS AND COMPATABILITY
> Two files are introduced:
>
> a) 'arch/mips/include/asm/mach-au1x00/au1xxx_ide.h'
> - containes : struct _auide_hwif
> + containes : struct auide_hwif
>
Contains?
Other than that,
Acked-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
MBR, Sergei
next prev parent reply other threads:[~2009-12-13 1:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-11 21:04 [PATCH] au1xxx-ide.c: ioremap() returns a void __iomem * H Hartley Sweeten
2009-12-12 22:54 ` Sergei Shtylyov [this message]
2009-12-14 4:52 ` David Miller
2009-12-14 17:27 ` H Hartley Sweeten
2009-12-14 17:49 ` H Hartley Sweeten
2009-12-15 5:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B241F10.7050706@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=davem@davemloft.net \
--cc=hartleys@visionengravers.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox