* [PATCH] pci: fix section mismatch on update_res()
@ 2009-12-15 1:19 Hidetoshi Seto
2009-12-16 19:30 ` Jesse Barnes
0 siblings, 1 reply; 2+ messages in thread
From: Hidetoshi Seto @ 2009-12-15 1:19 UTC (permalink / raw)
To: linux-kernel; +Cc: Jiri Slaby, Aristeu Sergio, Jesse Barnes, linux-pci, x86
From: Jiri Slaby <jslaby@suse.cz>
Remark update_res from __init to __devinit as it is called also
from __devinit functions.
This patch removes the following warning message:
WARNING: vmlinux.o(.devinit.text+0x774a): Section mismatch
in reference from the function pci_root_bus_res() to the
function .init.text:update_res()
The function __devinit pci_root_bus_res() references
a function __init update_res().
If update_res is only used by pci_root_bus_res then
annotate update_res with a matching annotation.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Aristeu Sergio <arozansk@redhat.com>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: linux-pci@vger.kernel.org
Cc: x86@kernel.org
Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
---
arch/x86/pci/bus_numa.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/pci/bus_numa.c b/arch/x86/pci/bus_numa.c
index 145df00..f939d60 100644
--- a/arch/x86/pci/bus_numa.c
+++ b/arch/x86/pci/bus_numa.c
@@ -51,7 +51,7 @@ void x86_pci_root_bus_res_quirks(struct pci_bus *b)
}
}
-void __init update_res(struct pci_root_info *info, size_t start,
+void __devinit update_res(struct pci_root_info *info, size_t start,
size_t end, unsigned long flags, int merge)
{
int i;
--
1.6.5.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pci: fix section mismatch on update_res()
2009-12-15 1:19 [PATCH] pci: fix section mismatch on update_res() Hidetoshi Seto
@ 2009-12-16 19:30 ` Jesse Barnes
0 siblings, 0 replies; 2+ messages in thread
From: Jesse Barnes @ 2009-12-16 19:30 UTC (permalink / raw)
To: Hidetoshi Seto; +Cc: linux-kernel, Jiri Slaby, Aristeu Sergio, linux-pci, x86
On Tue, 15 Dec 2009 10:19:50 +0900
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com> wrote:
> From: Jiri Slaby <jslaby@suse.cz>
>
> Remark update_res from __init to __devinit as it is called also
> from __devinit functions.
>
> This patch removes the following warning message:
>
> WARNING: vmlinux.o(.devinit.text+0x774a): Section mismatch
> in reference from the function pci_root_bus_res() to the
> function .init.text:update_res()
> The function __devinit pci_root_bus_res() references
> a function __init update_res().
> If update_res is only used by pci_root_bus_res then
> annotate update_res with a matching annotation.
>
> Signed-off-by: Jiri Slaby <jslaby@suse.cz>
> Cc: Aristeu Sergio <arozansk@redhat.com>
> Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
> Cc: linux-pci@vger.kernel.org
> Cc: x86@kernel.org
> Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
> ---
> arch/x86/pci/bus_numa.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/pci/bus_numa.c b/arch/x86/pci/bus_numa.c
> index 145df00..f939d60 100644
> --- a/arch/x86/pci/bus_numa.c
> +++ b/arch/x86/pci/bus_numa.c
> @@ -51,7 +51,7 @@ void x86_pci_root_bus_res_quirks(struct pci_bus *b)
> }
> }
>
> -void __init update_res(struct pci_root_info *info, size_t start,
> +void __devinit update_res(struct pci_root_info *info, size_t start,
> size_t end, unsigned long flags, int
> merge) {
> int i;
Applied, thanks Hidetoshi-san and Jiri.
--
Jesse Barnes, Intel Open Source Technology Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-16 19:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-15 1:19 [PATCH] pci: fix section mismatch on update_res() Hidetoshi Seto
2009-12-16 19:30 ` Jesse Barnes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox