From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753379AbZLOHkA (ORCPT ); Tue, 15 Dec 2009 02:40:00 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752635AbZLOHj5 (ORCPT ); Tue, 15 Dec 2009 02:39:57 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:57392 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752551AbZLOHj4 (ORCPT ); Tue, 15 Dec 2009 02:39:56 -0500 Message-ID: <4B273D27.5040009@cn.fujitsu.com> Date: Tue, 15 Dec 2009 15:39:19 +0800 From: Lai Jiangshan User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) MIME-Version: 1.0 To: Ingo Molnar , Steven Rostedt , Frederic Weisbecker , Masami Hiramatsu , Jason Baron , LKML Subject: [PATCH 01/10] trace_kprobe: shows signs of fields in format files Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org format files of trace_kprobe don't shows signs, it is different from all other format files, incorrect API to user. Signed-off-by: Lai Jiangshan Acked-by: Masami Hiramatsu --- diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c index e3c80e9..3ef66d4 100644 --- a/kernel/trace/trace_kprobe.c +++ b/kernel/trace/trace_kprobe.c @@ -1163,10 +1163,11 @@ static int __probe_event_show_format(struct trace_seq *s, #undef SHOW_FIELD #define SHOW_FIELD(type, item, name) \ do { \ - ret = trace_seq_printf(s, "\tfield: " #type " %s;\t" \ - "offset:%u;\tsize:%u;\n", name, \ + ret = trace_seq_printf(s, "\tfield:" #type " %s;\t" \ + "offset:%u;\tsize:%u;\tsigned:%d;\n", name,\ (unsigned int)offsetof(typeof(field), item),\ - (unsigned int)sizeof(type)); \ + (unsigned int)sizeof(type), \ + is_signed_type(type)); \ if (!ret) \ return 0; \ } while (0)