public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Masami Hiramatsu <mhiramat@redhat.com>,
	Jason Baron <jbaron@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 02/10] trace_syscalls: fix SYSCALL_DEFINE0
Date: Tue, 15 Dec 2009 15:39:26 +0800	[thread overview]
Message-ID: <4B273D2E.1010807@cn.fujitsu.com> (raw)


struct syscall_metadata variable name in SYSCALL_DEFINE0
is not the same as SYSCALL_DEFINE1/2/3/4/5/6.

SYSCALL_TRACE_ENTER_EVENT() and SYSCALL_TRACE_EXIT_EVENT() expect
struct syscall_metadata's name is __syscall_meta__XXXXXX
as SYSCALL_DEFINE1/2/3/4/5/6 defines.

It causes event_enter_##sname->data points to a wrong place.
(event_enter_##sname->data points to a dummy struct syscall_metadata)

It causes syscalls which are defined by SYSCALL_DEFINE0() can not be traced.

Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
---
diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h
index 55e7108..bee1d41 100644
--- a/include/linux/syscalls.h
+++ b/include/linux/syscalls.h
@@ -196,7 +196,7 @@ struct perf_event_attr;
 	static const struct syscall_metadata __used		\
 	  __attribute__((__aligned__(4)))			\
 	  __attribute__((section("__syscalls_metadata")))	\
-	  __syscall_meta_##sname = {				\
+	  __syscall_meta__##sname = {				\
 		.name 		= "sys_"#sname,			\
 		.nb_args 	= 0,				\
 		.enter_event	= &event_enter__##sname,	\









             reply	other threads:[~2009-12-15  7:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-15  7:39 Lai Jiangshan [this message]
2009-12-30 18:36 ` [tip:tracing/urgent] tracing/syscalls: Fix typo in SYSCALL_DEFINE0 tip-bot for Lai Jiangshan
  -- strict thread matches above, loose matches on Subject: below --
2009-12-09  7:15 [PATCH 02/10] trace_syscalls: fix SYSCALL_DEFINE0 Lai Jiangshan
2009-12-14 12:01 ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B273D2E.1010807@cn.fujitsu.com \
    --to=laijs@cn.fujitsu.com \
    --cc=fweisbec@gmail.com \
    --cc=jbaron@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@redhat.com \
    --cc=mingo@elte.hu \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox