* [PATCH] drbd: Fix test of unsigned in _drbd_fault_random()
@ 2009-12-15 21:55 Roel Kluin
0 siblings, 0 replies; only message in thread
From: Roel Kluin @ 2009-12-15 21:55 UTC (permalink / raw)
To: drbd-dev, drbd-user, Andrew Morton, LKML
rsp->count is unsigned so the test does not work.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
Found using coccinelle: http://coccinelle.lip6.fr/
diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c
index 157d1e4..c2594c1 100644
--- a/drivers/block/drbd/drbd_main.c
+++ b/drivers/block/drbd/drbd_main.c
@@ -3623,7 +3623,7 @@ _drbd_fault_random(struct fault_random_state *rsp)
{
long refresh;
- if (--rsp->count < 0) {
+ if (!rsp->count--) {
get_random_bytes(&refresh, sizeof(refresh));
rsp->state += refresh;
rsp->count = FAULT_RANDOM_REFRESH;
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2009-12-15 21:53 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-15 21:55 [PATCH] drbd: Fix test of unsigned in _drbd_fault_random() Roel Kluin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox