Re: [tip:x86/urgent] Makefile: set LC_CTYPE, LC_COLLATE, LC_NUMERIC to C

H. Peter Anvin
2009-12-17T23:41:43Z

[-- Attachment #1: Type: text/plain, Size: 272 bytes --]

On 12/17/2009 03:37 PM, H. Peter Anvin wrote:
>>
>> Maybe, "LC_ALL=" line broke it?
>
> What happens if you remove that part?
>

I mean, of course, the references to LC_ALL.

What would be even better, actually, would be to test the following
incremental patch:

-hpa

[-- Attachment #2: diff --]
[-- Type: text/plain, Size: 486 bytes --]

diff --git a/Makefile b/Makefile
index 6e39af1..5e92ca5 100644
--- a/Makefile
+++ b/Makefile
@@ -17,11 +17,11 @@ NAME = Man-Eating Seals of Antiquity
MAKEFLAGS += -rR --no-print-directory

# Avoid funny character set dependencies
-LC_ALL=
+unexport LC_ALL
LC_CTYPE=C
LC_COLLATE=C
LC_NUMERIC=C
-export LC_ALL LC_CTYPE LC_COLLATE LC_NUMERIC
+export LC_CTYPE LC_COLLATE LC_NUMERIC

# We are using a recursive build, so we need to do a little thinking
# to get the ordering right.