public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: "Américo Wang" <xiyou.wangcong@gmail.com>
Cc: law_ence.dev@ntlworld.com, Mark Hounschell <markh@compro.net>,
	linux-kernel@vger.kernel.org
Subject: Re: Unable to format or use floppies since 2.6.28
Date: Thu, 17 Dec 2009 18:19:07 +0900	[thread overview]
Message-ID: <4B29F78B.4080908@kernel.org> (raw)
In-Reply-To: <2375c9f90912170104s522f0b1bqe0ae76f42e8abf51@mail.gmail.com>

Hello,

On 12/17/2009 06:04 PM, Américo Wang wrote:
> On Sat, Dec 12, 2009 at 5:33 PM, ael <ael@none.none> wrote:
>> Mark Hounschell wrote:
>>>
>>> I have many boxes. They all do the same thing. Running different versions
>>> of SuSE, 10.3-11.2. Any kernel at or above 2.6.28 fails to fdformat a
>>> floppy. These same machines, using the same floppies and drives, running
>>> kernels older than 2.6.28 work just fine. I googled and found other such
>>> reports but no solution. I know better than to just assume it's a kernel bug
>>> but it sure looks like it could be so I'm inquiring about it here.

Hmmm... Strange.

>>> # fdformat /dev/fd0u1440
>>> Double-sided, 80 tracks, 18 sec/track. Total capacity 1440 kB.
>>> Formatting ... done
>>> Verifying ... Problem reading cylinder 1, expected 18432, read 2048
>>
>> Similar problems on debian testing: see
>> http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=548434
>>
>> However, fdformat is ok on Gentoo under 2.6.31 and also on Ubuntu
>> 2.6.32-rc6, so it seems it is not just the kernel version in any
>> simplistic way.

Double strange.

>> A git-bisect seems the obvious next step?
> 
> Wait...
> 
> There are only 13 changes related to floppy since 2.6.28, kick out 2 changes
> which just did some constifying, there are 11 only.
> 
> The most suspicious one should be commit 1011c1b9f2e from Tejun.
> 
> Mark, reverting that patch can help?

I don't think you can back that single patch out.  There were a lot of
cleanups in request handling after that.  How about trying 2.6.32
vanilla kernel?  Does it work?  How about copying fdformat from suse
to gentoo?

Thanks.

-- 
tejun

  reply	other threads:[~2009-12-17  9:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-10 19:46 Unable to format or use floppies since 2.6.28 Mark Hounschell
2009-12-12  9:33 ` ael
2009-12-17  9:04   ` Américo Wang
2009-12-17  9:19     ` Tejun Heo [this message]
2009-12-17  8:30 ` Dan Carpenter
2009-12-17 10:07 ` Mark Hounschell
2009-12-17 10:35   ` Mark Hounschell
2009-12-17 10:36     ` Alain Knaff
2009-12-17 10:45       ` Mark Hounschell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B29F78B.4080908@kernel.org \
    --to=tj@kernel.org \
    --cc=law_ence.dev@ntlworld.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markh@compro.net \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox