Re: [PATCH] spi: xilinx_spi: Fix up I/O routine wrapping bogosity.

Grant Likely
2009-12-17T17:01:52Z

On Tue, Dec 15, 2009 at 10:01 PM, Paul Mundt <lethal@linux-sh.org> wrote:
> xilinx_spi presently makes some fairly questionable assumptions about I/O
> routines, and attempts to assign ioread32/iowrite32 and friends directly
> to its own internal function pointers. On many platforms these I/O
> routines are macros or wrappers and not actual functions on their own,
> resulting in things like:
>
> ERROR: "ioread32be" [drivers/spi/xilinx_spi.ko] undefined!
> ERROR: "iowrite32be" [drivers/spi/xilinx_spi.ko] undefined!
> ERROR: "iowrite32" [drivers/spi/xilinx_spi.ko] undefined!
> ERROR: "ioread32" [drivers/spi/xilinx_spi.ko] undefined!

Unfortunately, ARM doesn't have either ioread32be or iowrite32be
defined, so the problem is still not solved with this patch. I've
crafted a patch to add them which I'll send to the ARM list right now.

g.

--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.