Re: [PATCH] move eject code from zd1211rw to usb-storage

Matthew Dharm
2009-12-15T18:03:52Z

[-- Attachment #1: Type: text/plain, Size: 1475 bytes --]

On Tue, Dec 15, 2009 at 04:11:08PM +0100, Oliver Neukum wrote:
> Am Dienstag, 15. Dezember 2009 13:31:13 schrieb Josua Dietze:
> > Stefan Seyfried schrieb:
> >
> > > The USB ID claimed by zd1211rw for the fake storage device is
> > > also in use by other, non-zd1211rw devices (Sphairon Homelink
> > > 1202). Move the eject of these devices to where it belongs and
> > > where all the needed infrastructure already exists: usb-storage.
> >
> >
> > We can do the eject (as other mode switches) in userspace. Previous
> > discussions pointed into that direction.
> >
> > And there is always the question of being able to access the "fake
> > CD-ROM" without hacking the kernel.
> >
> > I'd like to see these devices removed from unusual_devs.h.
>
> This would break existing systems and thus introduce a regression.
> We'd need to go through a feature removal process. For the time being
> I see no alternative to Seife's patch, as we cannot introduce ejection
> code to another wireless driver and need to support these devices.

The right answer here is neither to move the eject code nor to introduce
more of it. New devices should be supported via userspace.

Matt

--
Matthew Dharm Home: mdharm-usb@one-eyed-alien.net
Maintainer, Linux USB Mass Storage Driver

A: The most ironic oxymoron wins ...
DP: "Microsoft Works"
A: Uh, okay, you win.
-- A.J. & Dust Puppy
User Friendly, 1/18/1998

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]