Re: [PATCH] move eject code from zd1211rw to usb-storage

Josua Dietze
2009-12-16T11:42:33Z

Oliver Neukum schrieb:

> Am Dienstag, 15. Dezember 2009 19:03:00 schrieb Matthew Dharm:
>>> This would break existing systems and thus introduce a regression.
>>> We'd need to go through a feature removal process. For the time being
>>> I see no alternative to Seife's patch, as we cannot introduce ejection
>>> code to another wireless driver and need to support these devices.
>> The right answer here is neither to move the eject code nor to introduce
>> more of it. New devices should be supported via userspace.
>
> Usually I would agree, but in this case the vendor reused IDs.
> The legacy kernel space switcher and user space would race.

User space can test for device/interface class (which will
supposedly change even if the IDs do not) and base it's actions on
that. It was done before.

Apart from that issue, I can see that there is a problem with a
device that has worked without "external" handling up to now.
Unfortunately, I can't think about a clean solution.

Josua
--
Man is the only creature on earth enabled to take a
warm meal while flying! Loriot