From: "Thomas Hellström" <thomas@shipmail.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Dave Airlie <airlied@gmail.com>, David Airlie <airlied@linux.ie>,
Frederic Weisbecker <fweisbec@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
dri-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: convert drm_ioctl to unlocked_ioctl
Date: Fri, 18 Dec 2009 13:15:54 +0100 [thread overview]
Message-ID: <4B2B727A.7020806@shipmail.org> (raw)
In-Reply-To: <200912180916.27201.arnd@arndb.de>
Arnd Bergmann wrote:
> On Friday 18 December 2009, Dave Airlie wrote:
>
>> This looks good, I've taken this and I've squashed
>> the generic pieces of your RFC into this (i.e.
>> I haven't modified the drivers, but just added the
>> flag to allow the ioctls to be unlocked if the driver
>> selects them).
>>
>> Do you think we should try and get this in soon,
>> its seems like it shouldn't have any regressions
>> unless we start switching drivers over.
>>
>
> Well, since the patch should not change the behaviour
> of the drivers, it probably doesn't matter to users
> either way. However, it touches a number of places,
> which can break patches that others are working on,
> so maybe you should get it upstream at a point that
> has the least impact to developer (possibly now).
>
> Doing it now at least makes it easier to test
> moving drivers to unlocked operation.
>
> Arnd
>
I'm very much for this as well.
Note that the vmwgfx driver has another (workaround-like) approach to
achieve
unlocked driver ioctls, but it shouldn't be too hard to convert it.
/Thomas
> ------------------------------------------------------------------------------
> This SF.Net email is sponsored by the Verizon Developer Community
> Take advantage of Verizon's best-in-class app development support
> A streamlined, 14 day to market process makes app distribution fast and easy
> Join now and get one step closer to millions of Verizon customers
> http://p.sf.net/sfu/verizon-dev2dev
> --
> _______________________________________________
> Dri-devel mailing list
> Dri-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/dri-devel
>
prev parent reply other threads:[~2009-12-18 12:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-16 22:17 [PATCH] drm: convert drm_ioctl to unlocked_ioctl Arnd Bergmann
2009-12-17 0:04 ` [RFC] drm: allow unlocked ioctls in drivers Arnd Bergmann
2009-12-18 1:27 ` [PATCH] drm: convert drm_ioctl to unlocked_ioctl Dave Airlie
2009-12-18 8:16 ` Arnd Bergmann
2009-12-18 12:15 ` Thomas Hellström [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B2B727A.7020806@shipmail.org \
--to=thomas@shipmail.org \
--cc=airlied@gmail.com \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=dri-devel@lists.sourceforge.net \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox