From: Andi Kleen <ak@linux.intel.com>
To: Thiago Farina <tfransosi@gmail.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
Frederic Weisbecker <fweisbec@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Arjan van de Ven <arjan@linux.intel.com>,
Steven Rostedt <rostedt@goodmis.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Yinghai Lu <yinghai@kernel.org>
Subject: Re: [PATCH 1/2] kernel: Use CALLER_ADDR0 macro.
Date: Sun, 20 Dec 2009 20:03:55 +0100 [thread overview]
Message-ID: <4B2E751B.8050706@linux.intel.com> (raw)
In-Reply-To: <1261332469-25298-1-git-send-email-tfransosi@gmail.com>
Thiago Farina wrote:
> Use CALLER_ADDR0 instead of (unsigned long)__builtin_return_address(0),
> since this macro was created for this.
>
> This patch was generated by:
> sed -i "s/(unsigned long)__builtin_return_address(0)/CALLER_ADDR0/g" path/to/file
The new macro looks more obfuscated than the old straight forward call.
I fail to see the improvement.
-Andi
next prev parent reply other threads:[~2009-12-20 19:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-20 18:07 [PATCH 1/2] kernel: Use CALLER_ADDR0 macro Thiago Farina
2009-12-20 18:07 ` [PATCH 2/2] gfs2: " Thiago Farina
2009-12-21 9:22 ` Steven Whitehouse
2009-12-21 13:43 ` Christoph Hellwig
2009-12-20 19:03 ` Andi Kleen [this message]
2009-12-28 10:10 ` [tip:core/cleanups] kernel: " tip-bot for Thiago Farina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B2E751B.8050706@linux.intel.com \
--to=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@linux.intel.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=tfransosi@gmail.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox