* [PATCH] elf_fdpic_core_dump(): fix build break in 2.6.33-rc1
@ 2009-12-21 2:04 Daisuke HATAYAMA
2009-12-21 2:14 ` Masami Hiramatsu
2009-12-21 3:07 ` Paul Mundt
0 siblings, 2 replies; 3+ messages in thread
From: Daisuke HATAYAMA @ 2009-12-21 2:04 UTC (permalink / raw)
To: linux-kernel; +Cc: mhiramat
The commit f6151dfea21496d43dbaba32cfcd9c9f404769bc causes build
break, so this patch fixes it together with the correction for printk
format.
Thanks.
Signed-off-by: Daisuke HATAYAMA <d.hatayama@jp.fujitsu.com>
---
fs/binfmt_elf_fdpic.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c
index c25256a..b0f2732 100644
--- a/fs/binfmt_elf_fdpic.c
+++ b/fs/binfmt_elf_fdpic.c
@@ -1798,11 +1798,11 @@ static int elf_fdpic_core_dump(struct coredump_params *cprm)
ELF_CORE_WRITE_EXTRA_DATA;
#endif
- if (file->f_pos != offset) {
+ if (cprm->file->f_pos != offset) {
/* Sanity check */
printk(KERN_WARNING
- "elf_core_dump: file->f_pos (%lld) != offset (%lld)\n",
- file->f_pos, offset);
+ "elf_fdpic_core_dump: cprm->file->f_pos (%lld) != offset (%lld)\n",
+ cprm->file->f_pos, offset);
}
end_coredump:
--
1.6.5.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] elf_fdpic_core_dump(): fix build break in 2.6.33-rc1
2009-12-21 2:04 [PATCH] elf_fdpic_core_dump(): fix build break in 2.6.33-rc1 Daisuke HATAYAMA
@ 2009-12-21 2:14 ` Masami Hiramatsu
2009-12-21 3:07 ` Paul Mundt
1 sibling, 0 replies; 3+ messages in thread
From: Masami Hiramatsu @ 2009-12-21 2:14 UTC (permalink / raw)
To: Daisuke HATAYAMA; +Cc: linux-kernel
Daisuke HATAYAMA wrote:
> The commit f6151dfea21496d43dbaba32cfcd9c9f404769bc causes build
> break, so this patch fixes it together with the correction for printk
> format.
>
> Thanks.
>
> Signed-off-by: Daisuke HATAYAMA <d.hatayama@jp.fujitsu.com>
Thanks for fixing that! looks good to me.
Reviewed-by: Masami Hiramatsu <mhiramat@redhat.com>
> ---
> fs/binfmt_elf_fdpic.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c
> index c25256a..b0f2732 100644
> --- a/fs/binfmt_elf_fdpic.c
> +++ b/fs/binfmt_elf_fdpic.c
> @@ -1798,11 +1798,11 @@ static int elf_fdpic_core_dump(struct coredump_params *cprm)
> ELF_CORE_WRITE_EXTRA_DATA;
> #endif
>
> - if (file->f_pos != offset) {
> + if (cprm->file->f_pos != offset) {
> /* Sanity check */
> printk(KERN_WARNING
> - "elf_core_dump: file->f_pos (%lld) != offset (%lld)\n",
> - file->f_pos, offset);
> + "elf_fdpic_core_dump: cprm->file->f_pos (%lld) != offset (%lld)\n",
> + cprm->file->f_pos, offset);
> }
>
> end_coredump:
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] elf_fdpic_core_dump(): fix build break in 2.6.33-rc1
2009-12-21 2:04 [PATCH] elf_fdpic_core_dump(): fix build break in 2.6.33-rc1 Daisuke HATAYAMA
2009-12-21 2:14 ` Masami Hiramatsu
@ 2009-12-21 3:07 ` Paul Mundt
1 sibling, 0 replies; 3+ messages in thread
From: Paul Mundt @ 2009-12-21 3:07 UTC (permalink / raw)
To: Daisuke HATAYAMA; +Cc: linux-kernel, mhiramat, dhowells
On Mon, Dec 21, 2009 at 11:04:31AM +0900, Daisuke HATAYAMA wrote:
> The commit f6151dfea21496d43dbaba32cfcd9c9f404769bc causes build
> break, so this patch fixes it together with the correction for printk
> format.
>
> Thanks.
>
> Signed-off-by: Daisuke HATAYAMA <d.hatayama@jp.fujitsu.com>
I was about to send the same patch.. :-)
Acked-by: Paul Mundt <lethal@linux-sh.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-12-21 3:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-21 2:04 [PATCH] elf_fdpic_core_dump(): fix build break in 2.6.33-rc1 Daisuke HATAYAMA
2009-12-21 2:14 ` Masami Hiramatsu
2009-12-21 3:07 ` Paul Mundt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox