* [PATCHv2 04/12]posix_acl: Add the check items
@ 2009-12-21 11:56 Liuwenyi
0 siblings, 0 replies; only message in thread
From: Liuwenyi @ 2009-12-21 11:56 UTC (permalink / raw)
To: akpm, adilger, viro, jmorris, joel.becker, serue, jack,
linux-ext4, linux-kernel, onlyflyer, strongzgy
move the ACL validation check in to fs/posix_acl.c.
Including nullpointer check and PTR_ERR check.
---
Signed-off-by: Liuwenyi <qingshenlwy@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Andreas Dilger <adilger@sun.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: James Morris <jmorris@namei.org>
Cc: Joel Becker <joel.becker@oracle.com>
Cc: Serge Hallyn <serue@us.ibm.com>
Cc: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
diff --git a/fs/ext3/acl.c b/fs/ext3/acl.c
index 82ba341..3758304 100644
--- a/fs/ext3/acl.c
+++ b/fs/ext3/acl.c
@@ -432,13 +432,11 @@ ext3_xattr_set_acl(struct dentry *dentry, const
char *name, const void *value,
if (value) {
acl = posix_acl_from_xattr(value, size);
- if (IS_ERR(acl))
- return PTR_ERR(acl);
- else if (acl) {
- error = posix_acl_valid(acl);
- if (error)
- goto release_and_out;
- }
+
+ error = posix_acl_valid(acl);
+ if (error)
+ goto release_and_out;
+
} else
acl = NULL;
--
Best Regards,
Liuwenyi
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2009-12-21 11:53 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-21 11:56 [PATCHv2 04/12]posix_acl: Add the check items Liuwenyi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox