From: Liuwenyi <qingshenlwy@gmail.com>
To: swhiteho@redhat.com, viro@zeniv.linux.org.uk,
joel.becker@oracle.com, jmorris@namei.org, hch@lst.de,
cluster-devel@redhat.com, linux-kernel@vger.kernel.org,
onlyflyer@gmail.com, strongzgy@gmail.com
Subject: [PATCHv2 07/12]posix_acl: Add the check items
Date: Mon, 21 Dec 2009 19:58:58 +0800 [thread overview]
Message-ID: <4B2F6302.5050302@gmail.com> (raw)
move the ACL validation check in to fs/posix_acl.c.
Including nullpointer check and PTR_ERR check.
---
Signed-off-by: Liuwenyi <qingshenlwy@gmail.com>
Cc: Steven Whitehouse <swhiteho@redhat.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Joel Becker <joel.becker@oracle.com>
Cc: James Morris <jmorris@namei.org>
Cc: Christoph Hellwig <hch@lst.de>
Cc: cluster-devel@redhat.com
Cc: linux-kernel@vger.kernel.org
---
diff --git a/fs/gfs2/acl.c b/fs/gfs2/acl.c
index 87ee309..462f4e3 100644
--- a/fs/gfs2/acl.c
+++ b/fs/gfs2/acl.c
@@ -284,17 +284,6 @@ static int gfs2_xattr_system_set(struct dentry
*dentry, const char *name,
goto set_acl;
acl = posix_acl_from_xattr(value, size);
- if (!acl) {
- /*
- * acl_set_file(3) may request that we set default ACLs with
- * zero length -- defend (gracefully) against that here.
- */
- goto out;
- }
- if (IS_ERR(acl)) {
- error = PTR_ERR(acl);
- goto out;
- }
error = posix_acl_valid(acl);
if (error)
--
Best Regards,
Liuwenyi
reply other threads:[~2009-12-21 11:55 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B2F6302.5050302@gmail.com \
--to=qingshenlwy@gmail.com \
--cc=cluster-devel@redhat.com \
--cc=hch@lst.de \
--cc=jmorris@namei.org \
--cc=joel.becker@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=onlyflyer@gmail.com \
--cc=strongzgy@gmail.com \
--cc=swhiteho@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox