public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCHv2 10/12]posix_acl: Add the check items
@ 2009-12-21 12:01 Liuwenyi
  0 siblings, 0 replies; only message in thread
From: Liuwenyi @ 2009-12-21 12:01 UTC (permalink / raw)
  To: mfasheh, joel.becker, tiger.yang, viro, jmorris, ocfs2-devel,
	linux-kernel, strongzgy, onlyflyer

move the ACL validation check in to fs/posix_acl.c.
Including nullpointer check and PTR_ERR check.

---
Signed-off-by: Liuwenyi <qingshenlwy@gmail.com>
Cc: Mark Fasheh <mfasheh@suse.com>
Cc: Joel Becker <joel.becker@oracle.com>
Cc: Tiger Yang <tiger.yang@oracle.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: James Morris <jmorris@namei.org>
Cc: ocfs2-devel@oss.oracle.com
Cc: linux-kernel@vger.kernel.org

---
diff --git a/fs/ocfs2/acl.c b/fs/ocfs2/acl.c
index e3e4741..b11c72c 100644
--- a/fs/ocfs2/acl.c
+++ b/fs/ocfs2/acl.c
@@ -408,13 +408,9 @@ static int ocfs2_xattr_set_acl(struct dentry
*dentry, const char *name,

if (value) {
acl = posix_acl_from_xattr(value, size);
- if (IS_ERR(acl))
- return PTR_ERR(acl);
- else if (acl) {
- ret = posix_acl_valid(acl);
- if (ret)
- goto cleanup;
- }
+ ret = posix_acl_valid(acl);
+ if (ret)
+ goto cleanup;
} else
acl = NULL;


-- 
Best Regards,
Liuwenyi


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2009-12-21 11:57 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-21 12:01 [PATCHv2 10/12]posix_acl: Add the check items Liuwenyi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox