From: "H. Peter Anvin" <hpa@zytor.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Michael Tokarev <mjt@tls.msk.ru>, Michal Marek <mmarek@suse.cz>,
Michael Guntsche <mike@it-loops.com>,
Oliver Hartkopp <oliver@hartkopp.net>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kbuild: correct size calculation of bzImgae / fix x86 boot
Date: Mon, 21 Dec 2009 11:09:26 -0800 [thread overview]
Message-ID: <4B2FC7E6.5030508@zytor.com> (raw)
In-Reply-To: <4B2FBE69.3080408@zytor.com>
On 12/21/2009 10:28 AM, H. Peter Anvin wrote:
> On 12/20/2009 06:11 AM, Sam Ravnborg wrote:
>>
>> The whole business using shell scripts to append the size seems broken.
>> How about moving this functionality to mkpiggy where we are
>> less shell script dependent.
>>
>
> Seems a helluva lot saner to me...
>
>> It includes the length also in the gzip case - I dunno if that matters.
>> Also I dunno if ".long" is the same on 32 and 64 bit.
>
> Well, gzip already has a length at the end... shouldn't really hurt
> anything, I suppose. ".long" is 32 bits on both 32 and 64 bits.
>
Note, though: mkpiggy is x86, but this also affects other
architectures... so probably additional changes are needed.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2009-12-21 19:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-19 23:34 2.6.33-rc1 Reboot right after bootloader Michael Guntsche
2009-12-20 8:46 ` Sam Ravnborg
2009-12-20 9:10 ` Johannes Stezenbach
2009-12-20 10:38 ` Michael Tokarev
2009-12-20 11:10 ` Michael Tokarev
2009-12-20 11:38 ` Michael Tokarev
2009-12-20 9:11 ` Michael Guntsche
2009-12-20 10:03 ` [PATCH] kbuild: correct size calculation of bzImgae / fix x86 boot Sam Ravnborg
2009-12-20 10:20 ` Oliver Hartkopp
2009-12-20 10:28 ` Willy Tarreau
2009-12-20 10:47 ` Michael Tokarev
2009-12-20 13:09 ` Willy Tarreau
2009-12-20 11:19 ` Michael Tokarev
2009-12-20 12:02 ` Andreas Schwab
2009-12-20 12:18 ` Sam Ravnborg
2009-12-21 12:23 ` Michal Marek
2009-12-21 13:50 ` Andreas Schwab
2009-12-20 14:11 ` Sam Ravnborg
2009-12-21 14:17 ` Michal Marek
2009-12-21 16:28 ` Michael Guntsche
2009-12-21 19:53 ` Michael Tokarev
2009-12-21 20:48 ` Michael Guntsche
2009-12-21 18:28 ` H. Peter Anvin
2009-12-21 19:09 ` H. Peter Anvin [this message]
2009-12-20 13:50 ` Arkadiusz Miskiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B2FC7E6.5030508@zytor.com \
--to=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mike@it-loops.com \
--cc=mjt@tls.msk.ru \
--cc=mmarek@suse.cz \
--cc=oliver@hartkopp.net \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox