Re: [PATCH] tracing: Fix lockdep warning in global_clock()

Peter Zijlstra
2009-12-21T14:41:14Z

On Mon, 2009-12-21 at 15:36 +0800, Li Zefan wrote:

> +++ b/kernel/sched_clock.c
> @@ -250,9 +250,9 @@ unsigned long long cpu_clock(int cpu)
> unsigned long long clock;
> unsigned long flags;
>
> - raw_local_irq_save(flags);
> + local_irq_save(flags);
> clock = sched_clock_cpu(cpu);
> - raw_local_irq_restore(flags);
> + local_irq_restore(flags);
>
> return clock;
> }
> ===============================================
>
> I guess it's still true that lower level functions can take locks?

No, I removed the locks from cpu_clock a while back.