Re: [PATCH] ARM: Convert BUG() to use unreachable()

David Daney
2009-12-08T19:16:20Z

Uwe Kleine-König wrote:
> Use the new unreachable() macro instead of for(;;);
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Cc: David Daney <ddaney@caviumnetworks.com>

This looks fine to me. The comment is somewhat redundant now, but still
accurate.

Reviewed-by: David Daney <ddaney@caviumnetworks.com>

> ---
> arch/arm/kernel/traps.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/kernel/traps.c b/arch/arm/kernel/traps.c
> index 3f361a7..25b50c4 100644
> --- a/arch/arm/kernel/traps.c
> +++ b/arch/arm/kernel/traps.c
> @@ -681,7 +681,7 @@ void __attribute__((noreturn)) __bug(const char *file, int line)
> *(int *)0 = 0;
>
> /* Avoid "noreturn function does return" */
> - for (;;);
> + unreachable();
> }
> EXPORT_SYMBOL(__bug);
>