[PATCH] MAINTAINERS: Fix entry for uwb to include subdirectories

[PATCH] MAINTAINERS: Fix entry for uwb to include subdirectories

[Peter Huewe]

This little patch removes the asterisk wildcard, in order to get the uwb
maintainer when using get_maintainer.pl on anyfiles in the
subdirectories of uwb.
Otherwise it get_maintainer.pl does not come up with a result

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
---
 MAINTAINERS |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index e770069..fbcc8f9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -5467,7 +5467,7 @@ ULTRA-WIDEBAND (UWB) SUBSYSTEM:
 M:	David Vrabel <david.vrabel@csr.com>
 L:	linux-usb@vger.kernel.org
 S:	Supported
-F:	drivers/uwb/*
+F:	drivers/uwb/
 F:	include/linux/uwb.h
 F:	include/linux/uwb/
 
-- 
1.6.4.4

Re: [PATCH] MAINTAINERS: Fix entry for uwb to include subdirectories

[Joe Perches]

On Tue, 2009-12-22 at 10:05 +0100, Peter Huewe wrote:
> This little patch removes the asterisk wildcard, in order to get the uwb
> maintainer when using get_maintainer.pl on anyfiles in the
> subdirectories of uwb.

Is this correct?
Does David Vrabel maintain drivers/uwb/i1480/ ?

drivers/uwb/wlp/ is separately maintained
WIMEDIA LLC PROTOCOL (WLP) SUBSYSTEM

> Otherwise it get_maintainer.pl does not come up with a result

Sure it does:
$ ./scripts/get_maintainer.pl -f drivers/uwb/i1480
Jiri Kosina <jkosina@suse.cz>
David Vrabel <david.vrabel@csr.com>
Stephen Hemminger <shemminger@vyatta.com>
David S. Miller <davem@davemloft.net>
Nick Andrew <nick@nick-andrew.net>
linux-kernel@vger.kernel.org

> diff --git a/MAINTAINERS b/MAINTAINERS
> index e770069..fbcc8f9 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -5467,7 +5467,7 @@ ULTRA-WIDEBAND (UWB) SUBSYSTEM:
>  M:	David Vrabel <david.vrabel@csr.com>
>  L:	linux-usb@vger.kernel.org
>  S:	Supported
> -F:	drivers/uwb/*
> +F:	drivers/uwb/
>  F:	include/linux/uwb.h
>  F:	include/linux/uwb/

Re: [PATCH] MAINTAINERS: Fix entry for uwb to include subdirectories

[Peter Hüwe]

Am Dienstag 22 Dezember 2009 10:22:15 schrieb Joe Perches:
> On Tue, 2009-12-22 at 10:05 +0100, Peter Huewe wrote:
> > This little patch removes the asterisk wildcard, in order to get the uwb
> > maintainer when using get_maintainer.pl on anyfiles in the
> > subdirectories of uwb.
> 
> Is this correct?
> Does David Vrabel maintain drivers/uwb/i1480/ ?
Okay I should have asked David first wether this is correct or not :) 
However I created a patch earlier today for 
uwb/i1480/i1480-est.c 
Subject was [PATCH 1/6] uwb/i1480: add __init/__exit macros
and was told by Marcel Holtmann:
>> @Jiri: As there is no maintainer, it seems it is up to you to decide :)
>actually David Vrabel is taking care of the UWB subsystem and everything
>related to it.

> 
> > Otherwise it get_maintainer.pl does not come up with a result
> 
> Sure it does:
> $ ./scripts/get_maintainer.pl -f drivers/uwb/i1480
> Jiri Kosina <jkosina@suse.cz>
> David Vrabel <david.vrabel@csr.com>
> Stephen Hemminger <shemminger@vyatta.com>
> David S. Miller <davem@davemloft.net>
> Nick Andrew <nick@nick-andrew.net>
> linux-kernel@vger.kernel.org

But it does not yield a result for any file within i1480:
$ ./scripts/get_maintainer.pl -f drivers/uwb/i1480/i1480-est.c
linux-kernel@vger.kernel.org
$

Regards,
Peter

Re: [PATCH] MAINTAINERS: Fix entry for uwb to include subdirectories

[Peter Hüwe]

Am Dienstag 22 Dezember 2009 10:22:15 schrieb Joe Perches:
> On Tue, 2009-12-22 at 10:05 +0100, Peter Huewe wrote:
> > This little patch removes the asterisk wildcard, in order to get the uwb
> > maintainer when using get_maintainer.pl on anyfiles in the
> > subdirectories of uwb.
> 
> Is this correct?
> Does David Vrabel maintain drivers/uwb/i1480/ ?
> 
> drivers/uwb/wlp/ is separately maintained
> WIMEDIA LLC PROTOCOL (WLP) SUBSYSTEM

Okay I guess it IS correct - if you look at the entries in MAINTAINERS:
both 
drivers/uwb/wlp/  and drivers/uwb/
are infact maintained by David - only the mailing list is missing from the 
second.

ULTRA-WIDEBAND (UWB) SUBSYSTEM:
M:  David Vrabel <david.vrabel@csr.com>
L:  linux-usb@vger.kernel.org
S:  Supported
F:  drivers/uwb/*
F:  include/linux/uwb.h
F:  include/linux/uwb/


WIMEDIA LLC PROTOCOL (WLP) SUBSYSTEM
M:  David Vrabel <david.vrabel@csr.com>
S:  Maintained
F:  include/linux/wlp.h
F:  drivers/uwb/wlp/

Re: [PATCH] MAINTAINERS: Fix entry for uwb to include subdirectories

[Joe Perches]

On Tue, 2009-12-22 at 11:30 +0100, Peter Hüwe wrote:
> Okay I guess it IS correct

Maybe it is.

David Vrabel should be able to ack/nack it.

By default, get_maintainer checks a 1 year history
for commits.  If a file hasn't had a modification
in over a year, it likely isn't maintained, it's
already perfect or it's obsolete.

You could change the get_maintainer history window
with --git-since=date

Anyway, if get_maintainer doesn't give you a result,
look at the git log for the file or look inside the
source code of the file itself.

Here's the _only_ commit for that file:

$ git log drivers/uwb/i1480/i1480-est.c
commit 1ba47da527121ff704f4e9f27a12c9f32db05022
Author: Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>
Date:   Wed Sep 17 16:34:20 2008 +0100

    uwb: add the i1480 DFU driver
    
    Add the driver for downloading the firmware to an Intel i1480 device.
    
    Signed-off-by: David Vrabel <david.vrabel@csr.com>

And in the file:

 * Copyright (C) 2005-2006 Intel Corporation
 * Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>

So you should add Inaky to your patch cc list.

cheers, Joe

Re: [PATCH] MAINTAINERS: Fix entry for uwb to include subdirectories

[David Vrabel]

Joe Perches wrote:
> On Tue, 2009-12-22 at 10:05 +0100, Peter Huewe wrote:
>> This little patch removes the asterisk wildcard, in order to get the uwb
>> maintainer when using get_maintainer.pl on anyfiles in the
>> subdirectories of uwb.
> 
> Is this correct?
> Does David Vrabel maintain drivers/uwb/i1480/ ?

Yes, it's basically obsolete hardware that Intel no longer develops
which is why it doesn't see many changes.  I'd just delete it except
there's a few people actually using it.

Neither the UWB or WLP maintainer entries are completely correct.  I'll
fix them up.

David
-- 
David Vrabel, Senior Software Engineer, Drivers
CSR, Churchill House, Cambridge Business Park,  Tel: +44 (0)1223 692562
Cowley Road, Cambridge, CB4 0WZ                 http://www.csr.com/


Member of the CSR plc group of companies. CSR plc registered in England and Wales, registered number 4187346, registered office Churchill House, Cambridge Business Park, Cowley Road, Cambridge, CB4 0WZ, United Kingdom