From: Masami Hiramatsu <mhiramat@redhat.com>
To: Simon Horman <horms@verge.net.au>
Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
"H. Peter Anvin" <hpa@zytor.com>, Michal Marek <mmarek@sues.cz>,
Roland Dreier <rdreier@cisco.com>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [patch] Makefile: Unexport LANG
Date: Fri, 25 Dec 2009 23:30:30 -0500 [thread overview]
Message-ID: <4B359166.3050106@redhat.com> (raw)
In-Reply-To: <20091224111300.GA31932@verge.net.au>
Simon Horman wrote:
> The recent changes to setting and unexport various LC_ variables
> produces a problem on my system (Debian sid).
>
> $ locale
> LANG=ja_JP.utf8
> LANGUAGE=ja_JP.utf8
> LC_CTYPE="ja_JP.utf8"
> LC_NUMERIC="ja_JP.utf8"
> LC_TIME="ja_JP.utf8"
> LC_COLLATE="ja_JP.utf8"
> LC_MONETARY="ja_JP.utf8"
> LC_MESSAGES="ja_JP.utf8"
> LC_PAPER="ja_JP.utf8"
> LC_NAME="ja_JP.utf8"
> LC_ADDRESS="ja_JP.utf8"
> LC_TELEPHONE="ja_JP.utf8"
> LC_MEASUREMENT="ja_JP.utf8"
> LC_IDENTIFICATION="ja_JP.utf8"
> LC_ALL=ja_JP.utf8
>
> Without this patch:
> $ make
> make[2]: ??: ?? make ? -jN ?????????: jobserver ??????????.
> make[2]: ??: ?? make ? -jN ?????????: jobserver ??????????.
>
> With this patch:
> $ make
> ...
> make[2]: warning: -jN forced in submake: disabling jobserver mode.
> make[2]: warning: -jN forced in submake: disabling jobserver mode.
> ...
>
> Cc: H. Peter Anvin <hpa@zytor.com>
> Cc: Michal Marek <mmarek@sues.cz>
> Cc: Roland Dreier <rdreier@cisco.com>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: Masami Hiramatsu <mhiramat@redhat.com>
> Signed-off-by: Simon Horman <horms@verge.net.au>
Tested on Fedora 11 too, and it works good. Thank you!
Tested-by: Masami Hiramatsu <mhiramat@redhat.com>
>
> Index: linux-2.6/Makefile
> ===================================================================
> --- linux-2.6.orig/Makefile 2009-12-24 22:09:29.000000000 +1100
> +++ linux-2.6/Makefile 2009-12-24 22:10:58.000000000 +1100
> @@ -17,6 +17,7 @@ NAME = Man-Eating Seals of Antiquity
> MAKEFLAGS += -rR --no-print-directory
>
> # Avoid funny character set dependencies
> +unexport LANG
> unexport LC_ALL
> LC_CTYPE=C
> LC_COLLATE=C
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Masami Hiramatsu
Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division
e-mail: mhiramat@redhat.com
next prev parent reply other threads:[~2009-12-26 4:31 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-24 11:13 [patch] Makefile: Unexport LANG Simon Horman
2009-12-26 4:30 ` Masami Hiramatsu [this message]
2009-12-26 5:14 ` H. Peter Anvin
2009-12-26 11:20 ` Simon Horman
2010-01-08 0:41 ` Simon Horman
2010-01-08 0:43 ` H. Peter Anvin
2010-01-08 2:45 ` Simon Horman
2010-01-08 2:59 ` Simon Horman
2010-01-08 11:57 ` Michal Marek
2010-01-08 12:16 ` [PATCH] Makefile: do not override LC_CTYPE Michal Marek
2010-01-08 18:50 ` H. Peter Anvin
2010-01-09 0:00 ` Simon Horman
2010-01-09 0:07 ` H. Peter Anvin
2010-01-09 0:09 ` Masami Hiramatsu
2010-01-09 0:16 ` H. Peter Anvin
2010-01-09 0:30 ` Masami Hiramatsu
2010-01-09 0:43 ` H. Peter Anvin
2010-01-09 0:53 ` Masami Hiramatsu
2010-01-11 9:52 ` Michal Marek
2010-01-11 10:52 ` Alan Cox
2010-01-12 0:50 ` H. Peter Anvin
2010-01-09 1:07 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B359166.3050106@redhat.com \
--to=mhiramat@redhat.com \
--cc=horms@verge.net.au \
--cc=hpa@zytor.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@sues.cz \
--cc=rdreier@cisco.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox