* [PATCH] dc395x: Decrease iteration for tag_number of max_command in start_scsi()
@ 2009-12-26 18:53 Roel Kluin
0 siblings, 0 replies; only message in thread
From: Roel Kluin @ 2009-12-26 18:53 UTC (permalink / raw)
To: James E.J. Bottomley, linux-scsi, Andrew Morton, LKML
The tag_number reaches dcb->max_command + 1 after the loop, but when
the tag_number equals dcb->max_command an error message is already
issued. The last iteration therefore appears obsolete.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
drivers/scsi/dc395x.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Or maybe we should allow a tag_number of dcb->max_command?
diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
index 6c59c02..f476b52 100644
--- a/drivers/scsi/dc395x.c
+++ b/drivers/scsi/dc395x.c
@@ -1596,7 +1596,7 @@ static u8 start_scsi(struct AdapterCtlBlk* acb, struct DeviceCtlBlk* dcb,
u32 tag_mask = 1;
u8 tag_number = 0;
while (tag_mask & dcb->tag_mask
- && tag_number <= dcb->max_command) {
+ && tag_number < dcb->max_command) {
tag_mask = tag_mask << 1;
tag_number++;
}
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2009-12-26 18:50 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-26 18:53 [PATCH] dc395x: Decrease iteration for tag_number of max_command in start_scsi() Roel Kluin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox