* [PATCH] wl1251: timeout one too soon in wl1251_boot_run_firmware()
@ 2009-12-26 19:31 Roel Kluin
2009-12-27 8:28 ` Kalle Valo
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-12-26 19:31 UTC (permalink / raw)
To: John W. Linville, linux-wireless, Andrew Morton, LKML
`loop' reaches INIT_LOOP + 1 after the loop. so if ACX_INTR_INIT_COMPLETE
occurs in the last iteration the write occurs but also the error out as if a
timeout occurred. This is probably very unlikely to ever occur.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
drivers/net/wireless/wl12xx/wl1251_boot.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/wl12xx/wl1251_boot.c b/drivers/net/wireless/wl12xx/wl1251_boot.c
index 2e733e7..28a8086 100644
--- a/drivers/net/wireless/wl12xx/wl1251_boot.c
+++ b/drivers/net/wireless/wl12xx/wl1251_boot.c
@@ -256,7 +256,7 @@ int wl1251_boot_run_firmware(struct wl1251 *wl)
}
}
- if (loop >= INIT_LOOP) {
+ if (loop > INIT_LOOP) {
wl1251_error("timeout waiting for the hardware to "
"complete initialization");
return -EIO;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] wl1251: timeout one too soon in wl1251_boot_run_firmware()
2009-12-26 19:31 [PATCH] wl1251: timeout one too soon in wl1251_boot_run_firmware() Roel Kluin
@ 2009-12-27 8:28 ` Kalle Valo
0 siblings, 0 replies; 2+ messages in thread
From: Kalle Valo @ 2009-12-27 8:28 UTC (permalink / raw)
To: Roel Kluin; +Cc: John W. Linville, linux-wireless, Andrew Morton, LKML
Roel Kluin <roel.kluin@gmail.com> writes:
> `loop' reaches INIT_LOOP + 1 after the loop. so if ACX_INTR_INIT_COMPLETE
> occurs in the last iteration the write occurs but also the error out as if a
> timeout occurred. This is probably very unlikely to ever occur.
Thank you for fixing this.
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Kalle Valo <kalle.valo@nokia.com>
I think John can take this. As Roel mentioned, this is nothing
critical and, if needed, can wait until 2.6.34.
--
Kalle Valo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-27 8:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-26 19:31 [PATCH] wl1251: timeout one too soon in wl1251_boot_run_firmware() Roel Kluin
2009-12-27 8:28 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox