* [PATCH] ALSA: test off by one in setsamplerate()
@ 2009-12-27 21:26 Roel Kluin
2009-12-28 11:35 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-12-27 21:26 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai, alsa-devel, Andrew Morton, LKML
With `while (i++ < MAX_WRITE_RETRY)' i reaches MAX_WRITE_RETRY + 1 after the loop
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
sound/pci/riptide/riptide.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/sound/pci/riptide/riptide.c b/sound/pci/riptide/riptide.c
index b5ca02e..e66ef2b 100644
--- a/sound/pci/riptide/riptide.c
+++ b/sound/pci/riptide/riptide.c
@@ -1058,7 +1058,7 @@ setsamplerate(struct cmdif *cif, unsigned char *intdec, unsigned int rate)
rptr.retwords[2] != M &&
rptr.retwords[3] != N &&
i++ < MAX_WRITE_RETRY);
- if (i == MAX_WRITE_RETRY) {
+ if (i > MAX_WRITE_RETRY) {
snd_printdd("sent samplerate %d: %d failed\n",
*intdec, rate);
return -EIO;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: test off by one in setsamplerate()
2009-12-27 21:26 [PATCH] ALSA: test off by one in setsamplerate() Roel Kluin
@ 2009-12-28 11:35 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2009-12-28 11:35 UTC (permalink / raw)
To: Roel Kluin; +Cc: Jaroslav Kysela, alsa-devel, Andrew Morton, LKML
At Sun, 27 Dec 2009 22:26:47 +0100,
Roel Kluin wrote:
>
> With `while (i++ < MAX_WRITE_RETRY)' i reaches MAX_WRITE_RETRY + 1 after the loop
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Applied now. Thanks.
Takashi
> ---
> sound/pci/riptide/riptide.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/pci/riptide/riptide.c b/sound/pci/riptide/riptide.c
> index b5ca02e..e66ef2b 100644
> --- a/sound/pci/riptide/riptide.c
> +++ b/sound/pci/riptide/riptide.c
> @@ -1058,7 +1058,7 @@ setsamplerate(struct cmdif *cif, unsigned char *intdec, unsigned int rate)
> rptr.retwords[2] != M &&
> rptr.retwords[3] != N &&
> i++ < MAX_WRITE_RETRY);
> - if (i == MAX_WRITE_RETRY) {
> + if (i > MAX_WRITE_RETRY) {
> snd_printdd("sent samplerate %d: %d failed\n",
> *intdec, rate);
> return -EIO;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-28 11:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-27 21:26 [PATCH] ALSA: test off by one in setsamplerate() Roel Kluin
2009-12-28 11:35 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox