Re: [PATCH 03/13] mm: Provide generic pmd_thp_or_huge()

Peter Xu
2024-01-02T05:37:39Z

On Mon, Dec 25, 2023 at 02:29:53PM +0800, Muchun Song wrote:
> > @@ -1355,6 +1355,10 @@ static inline int pmd_write(pmd_t pmd)
> > #endif /* pmd_write */
> > #endif /* CONFIG_TRANSPARENT_HUGEPAGE */
> > +#ifndef pmd_thp_or_huge
>
> I think it may be the time to rename to pmd_thp_or_hugetlb,
> the "huge" is really confusing. thp is not huge? Actually,
> it is huge. It is better to make it more specific from now on, like
> "hugetlb".

The rename will need to touch ARM code, which I wanted to avoid, see:

arch/arm64/include/asm/pgtable.h:#define pmd_thp_or_huge(pmd) (pmd_huge(pmd) || pmd_trans_huge(pmd))

So far this series only touches generic code. Would you mind I keep this
patch as-is, and leave renaming to later?

>
> BTW, please cc me via the new email (muchun.song@linux.dev) next edition.

Sure. Thanks for taking a look.

--
Peter Xu