From: Yinghai Lu <yinghai@kernel.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [PATCH -v2] x86: increase NR_IRQS and nr_irqs
Date: Mon, 28 Dec 2009 21:08:29 -0800 [thread overview]
Message-ID: <4B398ECD.1080506@kernel.org> (raw)
In-Reply-To: <20091228094707.GH24690@elte.hu>
have a system with lots of igb and ixgbe, when iov/vf are enabled for
them, we hit the limit of 3064.
when system have 20 pcie installed, and one card have 2 functions, and one
function need 64 msi-x,
may need 20 * 2 * 64 = 2560 for msi-x
but if iov and vf are enabled
may need 20 * 2 * 64 * 3 = 7680 for msi-x
assume system with 5 ioapic, nr_irqs_gsi will be 120.
NR_CPUS = 512, and nr_cpu_ids = 128
will have NR_IRQS = 256 + 512 * 64 = 33024
will have nr_irqs = 120 + 8 * 128 + 120 * 64 = 8824
when SPARSE_IRQ is not set, there is no increase with data
when NR_CPUS=128, and SPARSE_IRQ is set
text data bss dec hex filename
21837444 4216564 12480736 38534744 24bfe58 vmlinux.before
21837442 4216580 12480736 38534758 24bfe66 vmlinux.after
when NR_CPUS=4096, and SPARSE_IRQ is set
text data bss dec hex filename
21878619 5610244 13415392 40904255 270263f vmlinux.before
21878617 5610244 13415392 40904253 270263d vmlinux.after
-v2: update comments to address Ingo's concern
Signed-off-by: Yinghai Lu <yinghai@kernel.org>
---
arch/x86/include/asm/irq_vectors.h | 12 ++++++------
arch/x86/kernel/apic/io_apic.c | 2 +-
2 files changed, 7 insertions(+), 7 deletions(-)
Index: linux-2.6/arch/x86/include/asm/irq_vectors.h
===================================================================
--- linux-2.6.orig/arch/x86/include/asm/irq_vectors.h
+++ linux-2.6/arch/x86/include/asm/irq_vectors.h
@@ -154,21 +154,21 @@ static inline int invalid_vm86_irq(int i
#define NR_IRQS_LEGACY 16
-#define CPU_VECTOR_LIMIT ( 8 * NR_CPUS )
#define IO_APIC_VECTOR_LIMIT ( 32 * MAX_IO_APICS )
#ifdef CONFIG_X86_IO_APIC
# ifdef CONFIG_SPARSE_IRQ
+# define CPU_VECTOR_LIMIT (64 * NR_CPUS)
# define NR_IRQS \
(CPU_VECTOR_LIMIT > IO_APIC_VECTOR_LIMIT ? \
(NR_VECTORS + CPU_VECTOR_LIMIT) : \
(NR_VECTORS + IO_APIC_VECTOR_LIMIT))
# else
-# if NR_CPUS < MAX_IO_APICS
-# define NR_IRQS (NR_VECTORS + 4*CPU_VECTOR_LIMIT)
-# else
-# define NR_IRQS (NR_VECTORS + IO_APIC_VECTOR_LIMIT)
-# endif
+# define CPU_VECTOR_LIMIT (32 * NR_CPUS)
+# define NR_IRQS \
+ (CPU_VECTOR_LIMIT < IO_APIC_VECTOR_LIMIT ? \
+ (NR_VECTORS + CPU_VECTOR_LIMIT) : \
+ (NR_VECTORS + IO_APIC_VECTOR_LIMIT))
# endif
#else /* !CONFIG_X86_IO_APIC: */
# define NR_IRQS NR_IRQS_LEGACY
Index: linux-2.6/arch/x86/kernel/apic/io_apic.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/apic/io_apic.c
+++ linux-2.6/arch/x86/kernel/apic/io_apic.c
@@ -3840,7 +3840,7 @@ int __init arch_probe_nr_irqs(void)
/*
* for MSI and HT dyn irq
*/
- nr += nr_irqs_gsi * 16;
+ nr += nr_irqs_gsi * 64;
#endif
if (nr < nr_irqs)
nr_irqs = nr;
next prev parent reply other threads:[~2009-12-29 5:10 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-25 8:42 [PATCH] x86: increase NR_IRQS and nr_irqs Yinghai Lu
2009-12-28 9:47 ` Ingo Molnar
2009-12-29 5:08 ` Yinghai Lu [this message]
2009-12-30 12:21 ` [tip:x86/apic] x86: Increase " tip-bot for Yinghai Lu
2010-01-04 3:06 ` [PATCH -v2] x86: increase " Jesse Brandeburg
2010-01-04 3:20 ` Yinghai Lu
2010-01-04 6:56 ` Subject: [PATCH 1/2] x86: get back 15 vectors Yinghai Lu
2010-01-04 16:18 ` Eric W. Biederman
2010-01-04 18:40 ` Yinghai Lu
2010-01-04 19:04 ` Eric W. Biederman
2010-01-04 19:14 ` H. Peter Anvin
2010-01-04 19:01 ` H. Peter Anvin
2010-01-04 19:09 ` Eric W. Biederman
2010-01-04 19:35 ` Yinghai Lu
2010-01-04 19:45 ` Suresh Siddha
2010-01-04 19:50 ` H. Peter Anvin
2010-01-05 0:05 ` Suresh Siddha
2010-01-05 0:16 ` Yinghai Lu
2010-01-05 5:30 ` [tip:x86/apic] x86, apic: Reclaim IDT vectors 0x20-0x2f tip-bot for H. Peter Anvin
2010-01-04 19:48 ` Subject: [PATCH 1/2] x86: get back 15 vectors H. Peter Anvin
2010-01-04 20:06 ` Yinghai Lu
2010-01-04 20:14 ` Eric W. Biederman
2010-01-04 20:33 ` Yinghai Lu
2010-01-04 21:10 ` H. Peter Anvin
2010-01-04 21:20 ` Yinghai Lu
2010-01-04 21:33 ` H. Peter Anvin
2010-01-04 22:01 ` Yinghai Lu
2010-01-04 23:03 ` H. Peter Anvin
2010-01-04 23:32 ` Yinghai Lu
2010-01-04 23:38 ` H. Peter Anvin
2010-01-04 23:42 ` Yinghai Lu
2010-01-04 23:49 ` Yinghai Lu
2010-01-04 23:59 ` H. Peter Anvin
2010-01-05 5:30 ` [tip:x86/apic] x86, apic: Don't waste a vector to improve vector spread tip-bot for H. Peter Anvin
2010-01-04 20:08 ` Subject: [PATCH 1/2] x86: get back 15 vectors Eric W. Biederman
2010-01-04 6:58 ` [PATCH 2/2] x86: get more exact nr_irqs Yinghai Lu
2010-01-04 16:55 ` Eric W. Biederman
2010-01-04 19:03 ` Yinghai Lu
2010-01-04 19:16 ` Eric W. Biederman
2010-01-04 19:30 ` H. Peter Anvin
2010-01-04 19:47 ` Yinghai Lu
2010-01-04 20:05 ` Eric W. Biederman
2010-01-04 21:50 ` H. Peter Anvin
2010-01-04 6:59 ` [PATCH 1/2] x86: get back 15 vectors Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B398ECD.1080506@kernel.org \
--to=yinghai@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox