From: Roel Kluin <roel.kluin@gmail.com>
To: "James E.J. Bottomley" <James.Bottomley@suse.de>,
linux-scsi@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
kashyap.desai@lsi.com
Subject: [PATCH] mpt2sas: Fix &&/|| confusion in _scsih_sas_device_status_change_event()
Date: Wed, 30 Dec 2009 17:58:52 +0100 [thread overview]
Message-ID: <4B3B86CC.5010205@gmail.com> (raw)
This never evaluates to true.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
drivers/scsi/mpt2sas/mpt2sas_scsih.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/mpt2sas/mpt2sas_scsih.c b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
index efabea1..82c5474 100644
--- a/drivers/scsi/mpt2sas/mpt2sas_scsih.c
+++ b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
@@ -4363,7 +4363,7 @@ _scsih_sas_device_status_change_event(struct MPT2SAS_ADAPTER *ioc,
#endif
if (!(event_data->ReasonCode ==
- MPI2_EVENT_SAS_DEV_STAT_RC_INTERNAL_DEVICE_RESET &&
+ MPI2_EVENT_SAS_DEV_STAT_RC_INTERNAL_DEVICE_RESET ||
event_data->ReasonCode ==
MPI2_EVENT_SAS_DEV_STAT_RC_CMP_INTERNAL_DEV_RESET))
return;
next reply other threads:[~2009-12-30 16:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-30 16:58 Roel Kluin [this message]
2010-01-07 19:31 ` [PATCH] mpt2sas: Fix &&/|| confusion in _scsih_sas_device_status_change_event() Moore, Eric
2010-01-07 19:58 ` roel kluin
2010-01-12 21:54 ` Andrew Morton
2010-01-13 0:23 ` Moore, Eric
2010-01-13 0:38 ` Andrew Morton
2010-01-13 0:42 ` Moore, Eric
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B3B86CC.5010205@gmail.com \
--to=roel.kluin@gmail.com \
--cc=James.Bottomley@suse.de \
--cc=akpm@linux-foundation.org \
--cc=kashyap.desai@lsi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox