* tty: &&/|| confusion in mxser_get_ISA_conf()?
@ 2009-12-31 12:03 Roel Kluin
2009-12-31 12:34 ` Jiri Slaby
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2009-12-31 12:03 UTC (permalink / raw)
To: Andrew Morton, LKML
vi drivers/char/mxser.c +2460 and note:
if ((irq != regs[9]) || (irq != regs[10]))
Should this be an && ?
Roel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: tty: &&/|| confusion in mxser_get_ISA_conf()?
2009-12-31 12:03 tty: &&/|| confusion in mxser_get_ISA_conf()? Roel Kluin
@ 2009-12-31 12:34 ` Jiri Slaby
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Slaby @ 2009-12-31 12:34 UTC (permalink / raw)
To: Roel Kluin; +Cc: Andrew Morton, LKML
On 12/31/2009 01:03 PM, Roel Kluin wrote:
> vi drivers/char/mxser.c +2460 and note:
>
> if ((irq != regs[9]) || (irq != regs[10]))
>
> Should this be an && ?
I would say not. It's a check whether irq is the same for all chips. It
jumps to a true branch iff at least one irq of the 8 is different (there
are 4 in each register). Does it make sense?
--
js
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-12-31 12:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-31 12:03 tty: &&/|| confusion in mxser_get_ISA_conf()? Roel Kluin
2009-12-31 12:34 ` Jiri Slaby
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox