From: Steve Wise <swise@opengridcomputing.com>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: linux-kernel@vger.kernel.org, swise@chelsio.com,
Roland Dreier <rdreier@cisco.com>
Subject: Re: [PATCH] drivers/infiniband/hw/cxgb3/iwch_cm.c: use %pM to show MAC address
Date: Mon, 04 Jan 2010 09:08:51 -0600 [thread overview]
Message-ID: <4B420483.1000606@opengridcomputing.com> (raw)
In-Reply-To: <BD79186B4FD85F4B8E60E381CAEE19090200F66A@mi8nycmail19.Mi8.com>
Acked-by: Steve Wise <swise@opengridcomputing.com>
H Hartley Sweeten wrote:
> Use the %pM kernel extension to display the MAC address.
>
> The only difference in the output is that the MAC address is
> shown in the usual colon-separated hex notation.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Steve Wise <swise@chelsio.com>
>
> ---
>
> diff --git a/drivers/infiniband/hw/cxgb3/iwch_cm.c b/drivers/infiniband/hw/cxgb3/iwch_cm.c
> index 66b4135..d94388b 100644
> --- a/drivers/infiniband/hw/cxgb3/iwch_cm.c
> +++ b/drivers/infiniband/hw/cxgb3/iwch_cm.c
> @@ -1371,15 +1371,8 @@ static int pass_accept_req(struct t3cdev *tdev, struct sk_buff *skb, void *ctx)
> tim.mac_addr = req->dst_mac;
> tim.vlan_tag = ntohs(req->vlan_tag);
> if (tdev->ctl(tdev, GET_IFF_FROM_MAC, &tim) < 0 || !tim.dev) {
> - printk(KERN_ERR
> - "%s bad dst mac %02x %02x %02x %02x %02x %02x\n",
> - __func__,
> - req->dst_mac[0],
> - req->dst_mac[1],
> - req->dst_mac[2],
> - req->dst_mac[3],
> - req->dst_mac[4],
> - req->dst_mac[5]);
> + printk(KERN_ERR "%s bad dst mac %pM\n",
> + __func__, req->dst_mac);
> goto reject;
> }
>
>
next prev parent reply other threads:[~2010-01-04 15:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-30 19:54 [PATCH] drivers/infiniband/hw/cxgb3/iwch_cm.c: use %pM to show MAC address H Hartley Sweeten
2010-01-04 15:08 ` Steve Wise [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-01-05 16:43 H Hartley Sweeten
2010-01-07 9:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B420483.1000606@opengridcomputing.com \
--to=swise@opengridcomputing.com \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=swise@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox