* [PATCH] drivers/infiniband/hw/cxgb3/iwch_cm.c: use %pM to show MAC address
@ 2009-12-30 19:54 H Hartley Sweeten
2010-01-04 15:08 ` Steve Wise
0 siblings, 1 reply; 4+ messages in thread
From: H Hartley Sweeten @ 2009-12-30 19:54 UTC (permalink / raw)
To: linux-kernel; +Cc: swise
Use the %pM kernel extension to display the MAC address.
The only difference in the output is that the MAC address is
shown in the usual colon-separated hex notation.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Steve Wise <swise@chelsio.com>
---
diff --git a/drivers/infiniband/hw/cxgb3/iwch_cm.c b/drivers/infiniband/hw/cxgb3/iwch_cm.c
index 66b4135..d94388b 100644
--- a/drivers/infiniband/hw/cxgb3/iwch_cm.c
+++ b/drivers/infiniband/hw/cxgb3/iwch_cm.c
@@ -1371,15 +1371,8 @@ static int pass_accept_req(struct t3cdev *tdev, struct sk_buff *skb, void *ctx)
tim.mac_addr = req->dst_mac;
tim.vlan_tag = ntohs(req->vlan_tag);
if (tdev->ctl(tdev, GET_IFF_FROM_MAC, &tim) < 0 || !tim.dev) {
- printk(KERN_ERR
- "%s bad dst mac %02x %02x %02x %02x %02x %02x\n",
- __func__,
- req->dst_mac[0],
- req->dst_mac[1],
- req->dst_mac[2],
- req->dst_mac[3],
- req->dst_mac[4],
- req->dst_mac[5]);
+ printk(KERN_ERR "%s bad dst mac %pM\n",
+ __func__, req->dst_mac);
goto reject;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers/infiniband/hw/cxgb3/iwch_cm.c: use %pM to show MAC address
2009-12-30 19:54 [PATCH] drivers/infiniband/hw/cxgb3/iwch_cm.c: use %pM to show MAC address H Hartley Sweeten
@ 2010-01-04 15:08 ` Steve Wise
0 siblings, 0 replies; 4+ messages in thread
From: Steve Wise @ 2010-01-04 15:08 UTC (permalink / raw)
To: H Hartley Sweeten; +Cc: linux-kernel, swise, Roland Dreier
Acked-by: Steve Wise <swise@opengridcomputing.com>
H Hartley Sweeten wrote:
> Use the %pM kernel extension to display the MAC address.
>
> The only difference in the output is that the MAC address is
> shown in the usual colon-separated hex notation.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Steve Wise <swise@chelsio.com>
>
> ---
>
> diff --git a/drivers/infiniband/hw/cxgb3/iwch_cm.c b/drivers/infiniband/hw/cxgb3/iwch_cm.c
> index 66b4135..d94388b 100644
> --- a/drivers/infiniband/hw/cxgb3/iwch_cm.c
> +++ b/drivers/infiniband/hw/cxgb3/iwch_cm.c
> @@ -1371,15 +1371,8 @@ static int pass_accept_req(struct t3cdev *tdev, struct sk_buff *skb, void *ctx)
> tim.mac_addr = req->dst_mac;
> tim.vlan_tag = ntohs(req->vlan_tag);
> if (tdev->ctl(tdev, GET_IFF_FROM_MAC, &tim) < 0 || !tim.dev) {
> - printk(KERN_ERR
> - "%s bad dst mac %02x %02x %02x %02x %02x %02x\n",
> - __func__,
> - req->dst_mac[0],
> - req->dst_mac[1],
> - req->dst_mac[2],
> - req->dst_mac[3],
> - req->dst_mac[4],
> - req->dst_mac[5]);
> + printk(KERN_ERR "%s bad dst mac %pM\n",
> + __func__, req->dst_mac);
> goto reject;
> }
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] drivers/infiniband/hw/cxgb3/iwch_cm.c: use %pM to show MAC address
@ 2010-01-05 16:43 H Hartley Sweeten
2010-01-07 9:17 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: H Hartley Sweeten @ 2010-01-05 16:43 UTC (permalink / raw)
To: Linux Kernel; +Cc: swise, davem
Use the %pM kernel extension to display the MAC address.
The only difference in the output is that the MAC address is
shown in the usual colon-separated hex notation.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Acked-by: Steve Wise <swise@opengridcomputing.com>
Cc: David S. Miller <davem@davemloft.net>
---
Repost due to merge issues.
diff --git a/drivers/infiniband/hw/cxgb3/iwch_cm.c b/drivers/infiniband/hw/cxgb3/iwch_cm.c
index 66b4135..d94388b 100644
--- a/drivers/infiniband/hw/cxgb3/iwch_cm.c
+++ b/drivers/infiniband/hw/cxgb3/iwch_cm.c
@@ -1371,15 +1371,8 @@ static int pass_accept_req(struct t3cdev *tdev, struct sk_buff *skb, void *ctx)
tim.mac_addr = req->dst_mac;
tim.vlan_tag = ntohs(req->vlan_tag);
if (tdev->ctl(tdev, GET_IFF_FROM_MAC, &tim) < 0 || !tim.dev) {
- printk(KERN_ERR
- "%s bad dst mac %02x %02x %02x %02x %02x %02x\n",
- __func__,
- req->dst_mac[0],
- req->dst_mac[1],
- req->dst_mac[2],
- req->dst_mac[3],
- req->dst_mac[4],
- req->dst_mac[5]);
+ printk(KERN_ERR "%s bad dst mac %pM\n",
+ __func__, req->dst_mac);
goto reject;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drivers/infiniband/hw/cxgb3/iwch_cm.c: use %pM to show MAC address
2010-01-05 16:43 H Hartley Sweeten
@ 2010-01-07 9:17 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2010-01-07 9:17 UTC (permalink / raw)
To: hartleys; +Cc: linux-kernel, swise
From: H Hartley Sweeten <hartleys@visionengravers.com>
Date: Tue, 5 Jan 2010 09:43:16 -0700
> Use the %pM kernel extension to display the MAC address.
>
> The only difference in the output is that the MAC address is
> shown in the usual colon-separated hex notation.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Acked-by: Steve Wise <swise@opengridcomputing.com>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-01-07 9:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-30 19:54 [PATCH] drivers/infiniband/hw/cxgb3/iwch_cm.c: use %pM to show MAC address H Hartley Sweeten
2010-01-04 15:08 ` Steve Wise
-- strict thread matches above, loose matches on Subject: below --
2010-01-05 16:43 H Hartley Sweeten
2010-01-07 9:17 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox