Re: [PATCH v3] staging: add Broadcom Crystal HD driver

Re: [PATCH v3] staging: add Broadcom Crystal HD driver

[Greg KH]

On Mon, Jan 04, 2010 at 06:02:27PM -0500, Jarod Wilson wrote:
> This patch supersedes the earlier ones sent by Manu Abraham to add
> the Broadcom Crystal HD driver to the staging tree, per discussion
> with him about it. I've been working with Broadcom's Naren Sankar
> on this driver for a number of months, and had already talked Naren
> about submitting this on Broadcom's behalf, didn't expect anyone
> else to jump on submitting it as quickly as Manu did. ;)

Looks good, I'll queue it up tomorrow.

greg k-h

Re: [PATCH v3] staging: add Broadcom Crystal HD driver

[Jarod Wilson]

On 1/4/10 6:19 PM, Greg KH wrote:
> On Mon, Jan 04, 2010 at 06:02:27PM -0500, Jarod Wilson wrote:
>> This patch supersedes the earlier ones sent by Manu Abraham to add
>> the Broadcom Crystal HD driver to the staging tree, per discussion
>> with him about it. I've been working with Broadcom's Naren Sankar
>> on this driver for a number of months, and had already talked Naren
>> about submitting this on Broadcom's behalf, didn't expect anyone
>> else to jump on submitting it as quickly as Manu did. ;)
> 
> Looks good, I'll queue it up tomorrow.

Nb: it looks like the thing is so massive (~935k), its not showing up on
lkml (at least, not in a timely fashion), so for the interested:

<http://people.redhat.com/jwilson/misc/broadcom-crystalhd-decoder-driver-staging.patch>

Thanks much!

-- 
Jarod Wilson
jarod@redhat.com

Re: [PATCH v3] staging: add Broadcom Crystal HD driver

[Robert Hancock]

On 01/04/2010 05:34 PM, Jarod Wilson wrote:
> On 1/4/10 6:19 PM, Greg KH wrote:
>> On Mon, Jan 04, 2010 at 06:02:27PM -0500, Jarod Wilson wrote:
>>> This patch supersedes the earlier ones sent by Manu Abraham to add
>>> the Broadcom Crystal HD driver to the staging tree, per discussion
>>> with him about it. I've been working with Broadcom's Naren Sankar
>>> on this driver for a number of months, and had already talked Naren
>>> about submitting this on Broadcom's behalf, didn't expect anyone
>>> else to jump on submitting it as quickly as Manu did. ;)
>>
>> Looks good, I'll queue it up tomorrow.
>
> Nb: it looks like the thing is so massive (~935k), its not showing up on
> lkml (at least, not in a timely fashion), so for the interested:
>
> <http://people.redhat.com/jwilson/misc/broadcom-crystalhd-decoder-driver-staging.patch>
>
> Thanks much!

Literally the majority of the code is #defines for what looks like 
register bits, etc - is all that really necessary?

RE: [PATCH v3] staging: add Broadcom Crystal HD driver

[Naren (Narendra) Sankar]

The register bits come straight from the HW RTL. So this way there are no errors or typos. It would be easier for maintenance from our side since this is generated automagically. And when we add new HW, again it is a script that spews this out.

Not absolutely necessary, but worried that cleanups may cause more problems than fix. 


Naren Sankar (+1 408 218 6327)
Architect/PLM
Media PC, Broadband Communications Group
Broadcom Corp.

-----Original Message-----
From: Robert Hancock [mailto:hancockrwd@gmail.com] 
Sent: Monday, January 04, 2010 6:22 PM
To: Jarod Wilson
Cc: Greg KH; linux-kernel@vger.kernel.org; Scott Davilla; Naren (Narendra) Sankar; Manu Abraham
Subject: Re: [PATCH v3] staging: add Broadcom Crystal HD driver

On 01/04/2010 05:34 PM, Jarod Wilson wrote:
> On 1/4/10 6:19 PM, Greg KH wrote:
>> On Mon, Jan 04, 2010 at 06:02:27PM -0500, Jarod Wilson wrote:
>>> This patch supersedes the earlier ones sent by Manu Abraham to add
>>> the Broadcom Crystal HD driver to the staging tree, per discussion
>>> with him about it. I've been working with Broadcom's Naren Sankar
>>> on this driver for a number of months, and had already talked Naren
>>> about submitting this on Broadcom's behalf, didn't expect anyone
>>> else to jump on submitting it as quickly as Manu did. ;)
>>
>> Looks good, I'll queue it up tomorrow.
>
> Nb: it looks like the thing is so massive (~935k), its not showing up on
> lkml (at least, not in a timely fashion), so for the interested:
>
> <http://people.redhat.com/jwilson/misc/broadcom-crystalhd-decoder-driver-staging.patch>
>
> Thanks much!

Literally the majority of the code is #defines for what looks like 
register bits, etc - is all that really necessary?

Re: [PATCH v3] staging: add Broadcom Crystal HD driver

[Jarod Wilson]

On Mon, Jan 4, 2010 at 9:36 PM, Naren (Narendra) Sankar
<nsankar@broadcom.com> wrote:
> The register bits come straight from the HW RTL. So this way there are no errors or typos. It would be easier for maintenance from our side since this is generated automagically. And when we add new HW, again it is a script that spews this out.
>
> Not absolutely necessary, but worried that cleanups may cause more problems than fix.

I think the automation is worth it to a point, but this header does
seem to be a wee bit excessive. I doubt if we're even using 1% of the
~12k defines in that one header, so we're bloating the code by a huge
amount for relatively little benefit. Its probably worth maintaining
the full register header *somewhere* (in with the userspace lib
somewhere?), but maybe we just do a trimmed down version for the
kernel module that contains only the bits we actually need.

> -----Original Message-----
> From: Robert Hancock [mailto:hancockrwd@gmail.com]
> Sent: Monday, January 04, 2010 6:22 PM
> To: Jarod Wilson
> Cc: Greg KH; linux-kernel@vger.kernel.org; Scott Davilla; Naren (Narendra) Sankar; Manu Abraham
> Subject: Re: [PATCH v3] staging: add Broadcom Crystal HD driver
>
> On 01/04/2010 05:34 PM, Jarod Wilson wrote:
>> On 1/4/10 6:19 PM, Greg KH wrote:
>>> On Mon, Jan 04, 2010 at 06:02:27PM -0500, Jarod Wilson wrote:
>>>> This patch supersedes the earlier ones sent by Manu Abraham to add
>>>> the Broadcom Crystal HD driver to the staging tree, per discussion
>>>> with him about it. I've been working with Broadcom's Naren Sankar
>>>> on this driver for a number of months, and had already talked Naren
>>>> about submitting this on Broadcom's behalf, didn't expect anyone
>>>> else to jump on submitting it as quickly as Manu did. ;)
>>>
>>> Looks good, I'll queue it up tomorrow.
>>
>> Nb: it looks like the thing is so massive (~935k), its not showing up on
>> lkml (at least, not in a timely fashion), so for the interested:
>>
>> <http://people.redhat.com/jwilson/misc/broadcom-crystalhd-decoder-driver-staging.patch>
>>
>> Thanks much!
>
> Literally the majority of the code is #defines for what looks like
> register bits, etc - is all that really necessary?
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>



-- 
Jarod Wilson
jarodwilson@gmail.com

Re: [PATCH v3] staging: add Broadcom Crystal HD driver

[Naren (Narendra) Sankar]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=utf-8, Size: 3164 bytes --]

That is ok by us. 

The driver does only use a small subset. 

Naren

----- Original Message -----
From: Jarod Wilson <jarodwilson@gmail.com>
To: Naren (Narendra) Sankar
Cc: Robert Hancock <hancockrwd@gmail.com>; Jarod Wilson <jarod@redhat.com>; Greg KH <greg@kroah.com>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>; Scott Davilla <davilla@4pi.com>; Manu Abraham <abraham.manu@gmail.com>
Sent: Mon Jan 04 22:58:29 2010Subject: Re: [PATCH v3] staging: add Broadcom Crystal HD driver

On Mon, Jan 4, 2010 at 9:36 PM, Naren (Narendra) Sankar
<nsankar@broadcom.com> wrote:
> The register bits come straight from the HW RTL. So this way there are no errors or typos. It would be easier for maintenance from our side since this is generated automagically. And when we add new HW, again it is a script that spews this out.
>
> Not absolutely necessary, but worried that cleanups may cause more problems than fix.

I think the automation is worth it to a point, but this header does
seem to be a wee bit excessive. I doubt if we're even using 1% of the
~12k defines in that one header, so we're bloating the code by a huge
amount for relatively little benefit. Its probably worth maintaining
the full register header *somewhere* (in with the userspace lib
somewhere?), but maybe we just do a trimmed down version for the
kernel module that contains only the bits we actually need.

> -----Original Message-----
> From: Robert Hancock [mailto:hancockrwd@gmail.com]
> Sent: Monday, January 04, 2010 6:22 PM
> To: Jarod Wilson
> Cc: Greg KH; linux-kernel@vger.kernel.org; Scott Davilla; Naren (Narendra) Sankar; Manu Abraham
> Subject: Re: [PATCH v3] staging: add Broadcom Crystal HD driver
>
> On 01/04/2010 05:34 PM, Jarod Wilson wrote:
>> On 1/4/10 6:19 PM, Greg KH wrote:
>>> On Mon, Jan 04, 2010 at 06:02:27PM -0500, Jarod Wilson wrote:
>>>> This patch supersedes the earlier ones sent by Manu Abraham to add
>>>> the Broadcom Crystal HD driver to the staging tree, per discussion
>>>> with him about it. I've been working with Broadcom's Naren Sankar
>>>> on this driver for a number of months, and had already talked Naren
>>>> about submitting this on Broadcom's behalf, didn't expect anyone
>>>> else to jump on submitting it as quickly as Manu did. ;)
>>>
>>> Looks good, I'll queue it up tomorrow.
>>
>> Nb: it looks like the thing is so massive (~935k), its not showing up on
>> lkml (at least, not in a timely fashion), so for the interested:
>>
>> <http://people.redhat.com/jwilson/misc/broadcom-crystalhd-decoder-driver-staging.patch>
>>
>> Thanks much!
>
> Literally the majority of the code is #defines for what looks like
> register bits, etc - is all that really necessary?
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>



-- 
Jarod Wilson
jarodwilson@gmail.com

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

Re: [PATCH v3] staging: add Broadcom Crystal HD driver

[Jarod Wilson]

Okay, cool. Greg, would you like an updated trimmed header before
adding this to staging, or can I just follow up later with a patch to
reduce the heft?

--jarod


On Tue, Jan 5, 2010 at 2:05 AM, Naren (Narendra) Sankar
<nsankar@broadcom.com> wrote:
> That is ok by us.
>
> The driver does only use a small subset.
>
> Naren
>
> ----- Original Message -----
> From: Jarod Wilson <jarodwilson@gmail.com>
> To: Naren (Narendra) Sankar
> Cc: Robert Hancock <hancockrwd@gmail.com>; Jarod Wilson <jarod@redhat.com>; Greg KH <greg@kroah.com>; linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>; Scott Davilla <davilla@4pi.com>; Manu Abraham <abraham.manu@gmail.com>
> Sent: Mon Jan 04 22:58:29 2010
> Subject: Re: [PATCH v3] staging: add Broadcom Crystal HD driver
>
> On Mon, Jan 4, 2010 at 9:36 PM, Naren (Narendra) Sankar
> <nsankar@broadcom.com> wrote:
>> The register bits come straight from the HW RTL. So this way there are no errors or typos. It would be easier for maintenance from our side since this is generated automagically. And when we add new HW, again it is a script that spews this out.
>>
>> Not absolutely necessary, but worried that cleanups may cause more problems than fix.
>
> I think the automation is worth it to a point, but this header does
> seem to be a wee bit excessive. I doubt if we're even using 1% of the
> ~12k defines in that one header, so we're bloating the code by a huge
> amount for relatively little benefit. Its probably worth maintaining
> the full register header *somewhere* (in with the userspace lib
> somewhere?), but maybe we just do a trimmed down version for the
> kernel module that contains only the bits we actually need.
>
>> -----Original Message-----
>> From: Robert Hancock [mailto:hancockrwd@gmail.com]
>> Sent: Monday, January 04, 2010 6:22 PM
>> To: Jarod Wilson
>> Cc: Greg KH; linux-kernel@vger.kernel.org; Scott Davilla; Naren (Narendra) Sankar; Manu Abraham
>> Subject: Re: [PATCH v3] staging: add Broadcom Crystal HD driver
>>
>> On 01/04/2010 05:34 PM, Jarod Wilson wrote:
>>> On 1/4/10 6:19 PM, Greg KH wrote:
>>>> On Mon, Jan 04, 2010 at 06:02:27PM -0500, Jarod Wilson wrote:
>>>>> This patch supersedes the earlier ones sent by Manu Abraham to add
>>>>> the Broadcom Crystal HD driver to the staging tree, per discussion
>>>>> with him about it. I've been working with Broadcom's Naren Sankar
>>>>> on this driver for a number of months, and had already talked Naren
>>>>> about submitting this on Broadcom's behalf, didn't expect anyone
>>>>> else to jump on submitting it as quickly as Manu did. ;)
>>>>
>>>> Looks good, I'll queue it up tomorrow.
>>>
>>> Nb: it looks like the thing is so massive (~935k), its not showing up on
>>> lkml (at least, not in a timely fashion), so for the interested:
>>>
>>> <http://people.redhat.com/jwilson/misc/broadcom-crystalhd-decoder-driver-staging.patch>
>>>
>>> Thanks much!
>>
>> Literally the majority of the code is #defines for what looks like
>> register bits, etc - is all that really necessary?
>>
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/
>>
>
>
>
> --
> Jarod Wilson
> jarodwilson@gmail.com
>
>



-- 
Jarod Wilson
jarodwilson@gmail.com

Re: [PATCH v3] staging: add Broadcom Crystal HD driver

[Greg KH]

On Tue, Jan 05, 2010 at 02:10:56AM -0500, Jarod Wilson wrote:
> Okay, cool. Greg, would you like an updated trimmed header before
> adding this to staging, or can I just follow up later with a patch to
> reduce the heft?

Later patches cleaning stuff up are best.

thanks,

greg k-h