From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755744Ab0AFKjL (ORCPT ); Wed, 6 Jan 2010 05:39:11 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755643Ab0AFKjJ (ORCPT ); Wed, 6 Jan 2010 05:39:09 -0500 Received: from cantor.suse.de ([195.135.220.2]:60366 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755584Ab0AFKjI (ORCPT ); Wed, 6 Jan 2010 05:39:08 -0500 Message-ID: <4B44684B.1060401@suse.cz> Date: Wed, 06 Jan 2010 11:39:07 +0100 From: Michal Marek User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091130 SUSE/3.0.0-1.2 Thunderbird/3.0 MIME-Version: 1.0 To: Eric Miao Cc: linux-kernel Subject: Re: [PATCH] kbuild: include only necessary in scripts/Makefile.modbuiltin References: <4B445D3E.8080600@suse.cz> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6.1.2010 11:31, Eric Miao wrote: > On Wed, Jan 6, 2010 at 5:51 PM, Michal Marek wrote: >> On 6.1.2010 07:26, Eric Miao wrote: >>> scripts/Makefile.modbuiltin assumes either Kbuild or Makefile exists in >>> every sub-directory, which is not true. >> >> It assumes what there is a kbuild file in each directory listed in >> subdir-[ym] or obj-[ym]. For which directory is this not true? Did you >> see an actual build failure? The same include is used in >> scripts/Makefile.build, where it has been working fine for ages... >> > > Well, it's in my tree outside mainline, I have to make this change > to get it build. And'm wondering if that's a correct assumption. And scripts/Makefile.build does not fail? Strange. Can you point me at the tree so that I can have a look? I assume it's some branch of git://git.kernel.org/pub/scm/linux/kernel/git/ycmiao/pxa-linux-2.6.git. Thanks, Michal