From: Michal Marek <mmarek@suse.cz>
To: John Kacur <jkacur@redhat.com>
Cc: linux-kernel@vger.kernel.org, Sam Ravnborg <sam@ravnborg.org>,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] Don't mkdir -p include/config in the sourcetree when using O=outputdir option
Date: Wed, 06 Jan 2010 20:34:32 +0100 [thread overview]
Message-ID: <4B44E5C8.2050006@suse.cz> (raw)
In-Reply-To: <alpine.LFD.2.00.1001061705140.3744@localhost.localdomain>
John Kacur napsal(a):
> The following is an example of how the Makefile currently can fail.
> [jkacur@tycho rt.linux.git]$ make mrproper
> [jkacur@tycho rt.linux.git]$ mkdir /bld/2.6.33-rc3
> [jkacur@tycho rt.linux.git]$ cp /bld/config /bld/2.6.33-rc3/.config
> [jkacur@tycho rt.linux.git]$ make O=/bld/2.6.33-rc3/ oldconfig
> HOSTCC scripts/basic/fixdep
> HOSTCC scripts/basic/docproc
> HOSTCC scripts/basic/hash
> GEN /bld/2.6.33-rc3/Makefile
> HOSTCC scripts/kconfig/conf.o
> HOSTCC scripts/kconfig/kxgettext.o
> HOSTCC scripts/kconfig/zconf.tab.o
> HOSTLD scripts/kconfig/conf
> scripts/kconfig/conf -o arch/x86/Kconfig
> [jkacur@tycho rt.linux.git]$ make O=/bld/2.6.33-rc3/
> GEN /bld/2.6.33-rc3/Makefile
> scripts/kconfig/conf -s arch/x86/Kconfig
> Using /home/jkacur/rt.linux.git as source for kernel
> /home/jkacur/rt.linux.git is not clean, please run 'make mrproper'
> in the '/home/jkacur/rt.linux.git' directory.
> make[1]: *** [prepare3] Error 1
> make: *** [sub-make] Error 2
> [jkacur@tycho rt.linux.git]$ ls -ld include/config/
> drwxrwxr-x 2 jkacur jkacur 6 2010-01-06 15:58 include/config/
>
> Signed-off-by: John Kacur <jkacur@redhat.com>
> ---
> Makefile | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 1231094..7d8d722 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -458,7 +458,7 @@ config: scripts_basic outputmakefile FORCE
> $(Q)$(MAKE) $(build)=scripts/kconfig $@
>
> %config: scripts_basic outputmakefile FORCE
> - $(Q)mkdir -p include/linux include/config
> + $(Q)mkdir -p $(objtree)/include/linux include/config
> $(Q)$(MAKE) $(build)=scripts/kconfig $@
Can you double-check that this patch really fixes your issue and that
without this patch it fails again? Because 1) I can't reproduce this
behaviour and I also don't see how it could f, 2) your problem is a
include/config file somehow created in the source tree, but you patch
the creation of include/linux. And if there really needs to be a fix,
the same should be applied to the identical block above.
thanks,
Michal
next prev parent reply other threads:[~2010-01-06 19:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-06 16:09 [PATCH] Don't mkdir -p include/config in the sourcetree when using O=outputdir option John Kacur
2010-01-06 19:34 ` Michal Marek [this message]
2010-01-06 20:10 ` John Kacur
2010-01-06 20:45 ` Michal Marek
2010-01-06 22:30 ` John Kacur
2010-01-06 22:33 ` John Kacur
2010-01-07 11:19 ` Michal Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B44E5C8.2050006@suse.cz \
--to=mmarek@suse.cz \
--cc=jkacur@redhat.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox