public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Simon Horman <horms@verge.net.au>
Cc: Masami Hiramatsu <mhiramat@redhat.com>,
	linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
	Michal Marek <mmarek@sues.cz>, Roland Dreier <rdreier@cisco.com>,
	Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [patch] Makefile: Unexport LANG
Date: Thu, 07 Jan 2010 16:43:55 -0800	[thread overview]
Message-ID: <4B467FCB.2080101@zytor.com> (raw)
In-Reply-To: <20100108004117.GK2436@verge.net.au>

On 01/07/2010 04:41 PM, Simon Horman wrote:
> On Sat, Dec 26, 2009 at 10:20:07PM +1100, Simon Horman wrote:
>> On Fri, Dec 25, 2009 at 09:14:40PM -0800, H. Peter Anvin wrote:
>>> On 12/25/2009 08:30 PM, Masami Hiramatsu wrote:
>>>>>  
>>>>>  # Avoid funny character set dependencies
>>>>> +unexport LANG
>>>>>  unexport LC_ALL
>>>>>  LC_CTYPE=C
>>>>>  LC_COLLATE=C
>>>>
>>>
>>> At this point, it seems to me that we should just LC_ALL=C and be done
>>> with it (see other thread.)
>>
>> Sure, that would also work for the case that I'm seeing.
>>
>> I tested the following:
>>
>> # Avoid funny character set dependencies
>> LC_ALL=C
>> export LC_ALL
>>
>> Though personally I would advocate tweaking the locale as needed closer
>> to awk scripts and the like, rather than the high-level general change that
>> was made. Fall-out from a high-level change seems inevitable to me.
> 
> This seems to still be broken. Can we decide on a solution?
> 

I think it's up to Michal to pick the preferred solution.

It has been pointed out that one option might also to be to *not*
override LC_CTYPE, and only override LC_COLLATE.

	-hpa



  reply	other threads:[~2010-01-08  0:44 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-24 11:13 [patch] Makefile: Unexport LANG Simon Horman
2009-12-26  4:30 ` Masami Hiramatsu
2009-12-26  5:14   ` H. Peter Anvin
2009-12-26 11:20     ` Simon Horman
2010-01-08  0:41       ` Simon Horman
2010-01-08  0:43         ` H. Peter Anvin [this message]
2010-01-08  2:45           ` Simon Horman
2010-01-08  2:59             ` Simon Horman
2010-01-08 11:57               ` Michal Marek
2010-01-08 12:16                 ` [PATCH] Makefile: do not override LC_CTYPE Michal Marek
2010-01-08 18:50                   ` H. Peter Anvin
2010-01-09  0:00                   ` Simon Horman
2010-01-09  0:07                     ` H. Peter Anvin
2010-01-09  0:09                   ` Masami Hiramatsu
2010-01-09  0:16                     ` H. Peter Anvin
2010-01-09  0:30                       ` Masami Hiramatsu
2010-01-09  0:43                         ` H. Peter Anvin
2010-01-09  0:53                       ` Masami Hiramatsu
2010-01-11  9:52                       ` Michal Marek
2010-01-11 10:52                       ` Alan Cox
2010-01-12  0:50                         ` H. Peter Anvin
2010-01-09  1:07                   ` Masami Hiramatsu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B467FCB.2080101@zytor.com \
    --to=hpa@zytor.com \
    --cc=horms@verge.net.au \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@redhat.com \
    --cc=mmarek@sues.cz \
    --cc=rdreier@cisco.com \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox