public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Randy Dunlap <rdunlap@xenotime.net>,
	linux-kbuild@vger.kernel.org,
	Artem Bityutskiy <dedekind1@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: sections mismatch detection
Date: Fri, 08 Jan 2010 17:32:51 +0100	[thread overview]
Message-ID: <4B475E33.4050407@suse.cz> (raw)
In-Reply-To: <20100108162759.GA16334@merkur.ravnborg.org>

Sam Ravnborg napsal(a):
> On Fri, Jan 08, 2010 at 02:18:56PM +0100, Michal Marek wrote:
>> Sam Ravnborg napsal(a):
>>>> I would prefer to see (logically) the same section mismatch not be
>>>> reported multiple times, even though they are in different binary
>>>> files.  This would reduce the noise level quite a bit IMO.
>>> That would be nice but is not trivially doable.
>>> We need to discover when there is a section mismatch
>>> resulting from for example a function in kernel/*
>>> calling a function in arch/$ARCH/kernel so we
>>> need to execute the check on multiple levels
>>> i order to catch the bugs as early as possible.
>>>
>>> The easy 'fix' would be to execute the check only
>>> on vmlinux.o (default behaviour) but the added
>>> checks with the option enabled allows us to
>>> be much more precise in reporting where
>>> the section mismatch originate from.
>> But we could remember the (caller,callee) pairs and only emit the first
>> warning. Or am I missing something?
> 
> The warnings comes from individual calls to mdpost.

Ah, that was the piece I was missing :).

Thanks,
Michal

      reply	other threads:[~2010-01-08 16:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-06 10:11 sections mismatch detection Artem Bityutskiy
2010-01-06 10:48 ` Sam Ravnborg
2010-01-06 11:38   ` Michal Marek
2010-01-06 12:04     ` Artem Bityutskiy
2010-01-07 23:03     ` Randy Dunlap
2010-01-08  5:42       ` Sam Ravnborg
2010-01-08 13:18         ` Michal Marek
2010-01-08 16:27           ` Sam Ravnborg
2010-01-08 16:32             ` Michal Marek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B475E33.4050407@suse.cz \
    --to=mmarek@suse.cz \
    --cc=dedekind1@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox