From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753903Ab0AHQcw (ORCPT ); Fri, 8 Jan 2010 11:32:52 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753871Ab0AHQcv (ORCPT ); Fri, 8 Jan 2010 11:32:51 -0500 Received: from cantor.suse.de ([195.135.220.2]:40906 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753845Ab0AHQcu (ORCPT ); Fri, 8 Jan 2010 11:32:50 -0500 Message-ID: <4B475E33.4050407@suse.cz> Date: Fri, 08 Jan 2010 17:32:51 +0100 From: Michal Marek User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: Sam Ravnborg Cc: Randy Dunlap , linux-kbuild@vger.kernel.org, Artem Bityutskiy , LKML Subject: Re: sections mismatch detection References: <1262772683.4263.147.camel@localhost> <20100106104823.GA30439@merkur.ravnborg.org> <4B44762C.1090605@suse.cz> <20100107150339.b66fadc5.rdunlap@xenotime.net> <20100108054144.GA15827@merkur.ravnborg.org> <4B4730C0.6000601@suse.cz> <20100108162759.GA16334@merkur.ravnborg.org> In-Reply-To: <20100108162759.GA16334@merkur.ravnborg.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sam Ravnborg napsal(a): > On Fri, Jan 08, 2010 at 02:18:56PM +0100, Michal Marek wrote: >> Sam Ravnborg napsal(a): >>>> I would prefer to see (logically) the same section mismatch not be >>>> reported multiple times, even though they are in different binary >>>> files. This would reduce the noise level quite a bit IMO. >>> That would be nice but is not trivially doable. >>> We need to discover when there is a section mismatch >>> resulting from for example a function in kernel/* >>> calling a function in arch/$ARCH/kernel so we >>> need to execute the check on multiple levels >>> i order to catch the bugs as early as possible. >>> >>> The easy 'fix' would be to execute the check only >>> on vmlinux.o (default behaviour) but the added >>> checks with the option enabled allows us to >>> be much more precise in reporting where >>> the section mismatch originate from. >> But we could remember the (caller,callee) pairs and only emit the first >> warning. Or am I missing something? > > The warnings comes from individual calls to mdpost. Ah, that was the piece I was missing :). Thanks, Michal