From: "H. Peter Anvin" <hpa@zytor.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"ebiederm@xmission.com" <ebiederm@xmission.com>,
"Maciej W. Rozycki" <macro@linux-mips.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [patch] x86, apic: use 0x20 for the IRQ_MOVE_CLEANUP_VECTOR instead of 0x1f
Date: Fri, 08 Jan 2010 19:20:46 -0800 [thread overview]
Message-ID: <4B47F60E.3040803@zytor.com> (raw)
In-Reply-To: <86802c441001081907y7d9c2439x2cb15f8bd7ea6709@mail.gmail.com>
On 01/08/2010 07:07 PM, Yinghai Lu wrote:
>> diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
>> index d5bfa29..5c090a1 100644
>> --- a/arch/x86/kernel/apic/io_apic.c
>> +++ b/arch/x86/kernel/apic/io_apic.c
>> @@ -1162,8 +1162,8 @@ __assign_irq_vector(int irq, struct irq_cfg *cfg, const struct cpumask *mask)
>> * Also, we've got to be careful not to trash gate
>> * 0x80, because int 0x80 is hm, kind of importantish. ;)
>> */
>> - static int current_vector = FIRST_DEVICE_VECTOR + VECTOR_OFFSET_START;
>> - static int current_offset = VECTOR_OFFSET_START % 8;
>> + static int current_vector = FIRST_DEVICE_VECTOR;
>> + static int current_offset = 0;
>> unsigned int old_vector;
>> int cpu, err;
>> cpumask_var_t tmp_mask;
>>
>
> looks like it returned to first version i suggested?
>
> http://lkml.org/lkml/2010/1/4/26
>
> maybe we can just kill FIRST_DEVICE_VECTOR...
>
As I already said, I really don't like reverting this bit.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2010-01-09 3:29 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-09 2:09 [patch] x86, apic: use 0x20 for the IRQ_MOVE_CLEANUP_VECTOR instead of 0x1f Suresh Siddha
2010-01-09 2:19 ` H. Peter Anvin
2010-01-09 2:50 ` Yinghai Lu
2010-01-11 22:53 ` Suresh Siddha
2010-01-11 22:57 ` H. Peter Anvin
2010-01-11 23:10 ` Eric W. Biederman
2010-01-11 23:13 ` H. Peter Anvin
2010-01-12 0:06 ` Suresh Siddha
2010-01-12 0:13 ` H. Peter Anvin
2010-01-12 0:28 ` Eric W. Biederman
2010-01-12 0:36 ` H. Peter Anvin
2010-01-12 1:52 ` Eric W. Biederman
2010-01-12 2:17 ` H. Peter Anvin
2010-01-12 2:27 ` Eric W. Biederman
2010-01-12 10:25 ` Alan Cox
2010-01-13 20:36 ` Eric W. Biederman
2010-01-13 20:38 ` H. Peter Anvin
2010-01-13 20:53 ` H. Peter Anvin
2010-01-13 20:58 ` H. Peter Anvin
2010-01-12 0:42 ` H. Peter Anvin
2010-01-11 23:00 ` Eric W. Biederman
2010-01-11 23:07 ` H. Peter Anvin
2010-01-09 3:07 ` Yinghai Lu
2010-01-09 3:20 ` H. Peter Anvin [this message]
2010-01-09 3:23 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B47F60E.3040803@zytor.com \
--to=hpa@zytor.com \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox