* [PATCH] musb: Test always evaluates to false
@ 2010-01-09 12:09 Roel Kluin
2010-01-29 10:39 ` Felipe Balbi
0 siblings, 1 reply; 2+ messages in thread
From: Roel Kluin @ 2010-01-09 12:09 UTC (permalink / raw)
To: Felipe Balbi, linux-usb, Andrew Morton, LKML
The removed part always evaluates to false.
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
drivers/usb/musb/musb_gadget.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
Was a different test intended?
diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c
index cbcf14a..1a19203 100644
--- a/drivers/usb/musb/musb_gadget.c
+++ b/drivers/usb/musb/musb_gadget.c
@@ -1697,8 +1697,7 @@ int usb_gadget_register_driver(struct usb_gadget_driver *driver)
return -EINVAL;
/* driver must be initialized to support peripheral mode */
- if (!musb || !(musb->board_mode == MUSB_OTG
- || musb->board_mode != MUSB_OTG)) {
+ if (!musb) {
DBG(1, "%s, no dev??\n", __func__);
return -ENODEV;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] musb: Test always evaluates to false
2010-01-09 12:09 [PATCH] musb: Test always evaluates to false Roel Kluin
@ 2010-01-29 10:39 ` Felipe Balbi
0 siblings, 0 replies; 2+ messages in thread
From: Felipe Balbi @ 2010-01-29 10:39 UTC (permalink / raw)
To: ext Roel Kluin
Cc: Balbi Felipe (Nokia-D/Helsinki), linux-usb@vger.kernel.org,
Andrew Morton, LKML
On Sat, Jan 09, 2010 at 01:09:01PM +0100, ext Roel Kluin wrote:
>The removed part always evaluates to false.
>
>Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Acked-by: Felipe Balbi <felipe.balbi@nokia.com>
--
balbi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-01-29 10:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-09 12:09 [PATCH] musb: Test always evaluates to false Roel Kluin
2010-01-29 10:39 ` Felipe Balbi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox