* [PATCH 2/3] nand: make USB device id constant
@ 2010-01-09 14:10 Németh Márton
0 siblings, 0 replies; only message in thread
From: Németh Márton @ 2010-01-09 14:10 UTC (permalink / raw)
To: David Woodhouse; +Cc: linux-mtd, Julia Lawall, cocci, LKML
From: Márton Németh <nm127@freemail.hu>
The id_table field of the struct usb_device_id is constant in <linux/usb.h>
so it is worth to make alauda_table also constant.
The semantic match that finds this kind of pattern is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r@
disable decl_init,const_decl_init;
identifier I1, I2, x;
@@
struct I1 {
...
const struct I2 *x;
...
};
@s@
identifier r.I1, y;
identifier r.x, E;
@@
struct I1 y = {
.x = E,
};
@c@
identifier r.I2;
identifier s.E;
@@
const struct I2 E[] = ... ;
@depends on !c@
identifier r.I2;
identifier s.E;
@@
+ const
struct I2 E[] = ...;
// </smpl>
Signed-off-by: Márton Németh <nm127@freemail.hu>
Cc: Julia Lawall <julia@diku.dk>
Cc: cocci@diku.dk
---
diff -u -p a/drivers/mtd/nand/alauda.c b/drivers/mtd/nand/alauda.c
--- a/drivers/mtd/nand/alauda.c 2010-01-07 19:08:42.000000000 +0100
+++ b/drivers/mtd/nand/alauda.c 2010-01-08 04:26:29.000000000 +0100
@@ -49,7 +49,7 @@
#define TIMEOUT HZ
-static struct usb_device_id alauda_table [] = {
+static const struct usb_device_id alauda_table[] = {
{ USB_DEVICE(0x0584, 0x0008) }, /* Fujifilm DPC-R1 */
{ USB_DEVICE(0x07b4, 0x010a) }, /* Olympus MAUSB-10 */
{ }
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-01-09 14:10 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-09 14:10 [PATCH 2/3] nand: make USB device id constant Németh Márton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox