public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 6/9] USB hub: make USB device id constant
@ 2010-01-10 14:34 Németh Márton
  0 siblings, 0 replies; only message in thread
From: Németh Márton @ 2010-01-10 14:34 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: linux-usb, LKML, Julia Lawall, cocci

From: Márton Németh <nm127@freemail.hu>

The id_table field of the struct usb_device_id is constant in <linux/usb.h>
so it is worth to make the initialization data also constant.

The semantic match that finds this kind of pattern is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r@
disable decl_init,const_decl_init;
identifier I1, I2, x;
@@
	struct I1 {
	  ...
	  const struct I2 *x;
	  ...
	};
@s@
identifier r.I1, y;
identifier r.x, E;
@@
	struct I1 y = {
	  .x = E,
	};
@c@
identifier r.I2;
identifier s.E;
@@
	const struct I2 E[] = ... ;
@depends on !c@
identifier r.I2;
identifier s.E;
@@
+	const
	struct I2 E[] = ...;
// </smpl>

Signed-off-by: Márton Németh <nm127@freemail.hu>
Cc: Julia Lawall <julia@diku.dk>
Cc: cocci@diku.dk
---
diff -u -p a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
--- a/drivers/usb/core/hub.c 2010-01-07 19:08:47.000000000 +0100
+++ b/drivers/usb/core/hub.c 2010-01-08 17:20:19.000000000 +0100
@@ -3442,7 +3442,7 @@ static int hub_thread(void *__unused)
 	return 0;
 }

-static struct usb_device_id hub_id_table [] = {
+static const struct usb_device_id hub_id_table[] = {
     { .match_flags = USB_DEVICE_ID_MATCH_DEV_CLASS,
       .bDeviceClass = USB_CLASS_HUB},
     { .match_flags = USB_DEVICE_ID_MATCH_INT_CLASS,

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-01-10 14:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-10 14:34 [PATCH 6/9] USB hub: make USB device id constant Németh Márton

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox