From: "Németh Márton" <nm127@freemail.hu>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] block: make PCI device id constant
Date: Sun, 10 Jan 2010 16:41:41 +0100 [thread overview]
Message-ID: <4B49F535.6080108@freemail.hu> (raw)
In-Reply-To: <20100110141106.GA4293@x200>
From: Márton Németh <nm127@freemail.hu>
Use DEFINE_PCI_DEVICE_TABLE() when declaring the PCI device
table as suggested in Documentation/PCI/pci.txt .
Signed-off-by: Márton Németh <nm127@freemail.hu>
---
--- drivers/block/DAC960.c.orig 2010-01-10 16:12:25.000000000 +0100
+++ drivers/block/DAC960.c 2010-01-10 16:16:26.000000000 +0100
@@ -7134,7 +7134,7 @@
.MemoryWindowSize = DAC960_PD_RegisterWindowSize,
};
-static struct pci_device_id DAC960_id_table[] = {
+static DEFINE_PCI_DEVICE_TABLE(DAC960_id_table) = {
{
.vendor = PCI_VENDOR_ID_MYLEX,
.device = PCI_DEVICE_ID_MYLEX_DAC960_GEM,
--- drivers/block/sx8.c.orig 2010-01-10 16:12:38.000000000 +0100
+++ drivers/block/sx8.c 2010-01-10 16:17:57.000000000 +0100
@@ -409,7 +409,7 @@
static void carm_remove_one (struct pci_dev *pdev);
static int carm_bdev_getgeo(struct block_device *bdev, struct hd_geometry *geo);
-static struct pci_device_id carm_pci_tbl[] = {
+static DEFINE_PCI_DEVICE_TABLE(carm_pci_tbl) = {
{ PCI_VENDOR_ID_PROMISE, 0x8000, PCI_ANY_ID, PCI_ANY_ID, 0, 0, },
{ PCI_VENDOR_ID_PROMISE, 0x8002, PCI_ANY_ID, PCI_ANY_ID, 0, 0, },
{ } /* terminate list */
next prev parent reply other threads:[~2010-01-10 15:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-10 14:11 [PATCH 1/5] block: make PCI device id constant Alexey Dobriyan
2010-01-10 15:41 ` Németh Márton [this message]
-- strict thread matches above, loose matches on Subject: below --
2010-01-10 12:39 Németh Márton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B49F535.6080108@freemail.hu \
--to=nm127@freemail.hu \
--cc=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox