[PATCH] error message when FLAT reloc symbol is invalid, v2

[PATCH] error message when FLAT reloc symbol is invalid, v2

[Jun Sun]

[-- Attachment #1: Type: text/plain, Size: 26 bytes --]

See the attachement.

Jun

[-- Attachment #2: 091231-flat-invalid-reloc-symbol-output.patch --]
[-- Type: text/plain, Size: 789 bytes --]

This patch fixes a cosmetic error in printk. Text segment and data/bss
segment are allocated from two different areas. It is not meaningful to
give the diff between them in the error reporting messages.

Signed-off-by: Jun Sun <jsun@junsun.net>
---

diff -Nru linux-2.6.32.2/fs/binfmt_flat.c.orig linux-2.6.32.2/fs/binfmt_flat.c
--- linux-2.6.32.2/fs/binfmt_flat.c.orig	2009-12-18 14:27:07.000000000 -0800
+++ linux-2.6.32.2/fs/binfmt_flat.c	2009-12-26 08:22:43.000000000 -0800
@@ -355,7 +355,7 @@
 
 	if (!flat_reloc_valid(r, start_brk - start_data + text_len)) {
 		printk("BINFMT_FLAT: reloc outside program 0x%x (0 - 0x%x/0x%x)",
-		       (int) r,(int)(start_brk-start_code),(int)text_len);
+		       (int) r,(int)(start_brk-start_data+text_len),(int)text_len);
 		goto failed;
 	}
 

Re: [uClinux-dev] [PATCH] error message when FLAT reloc symbol is invalid, v2

[Mike Frysinger]

[-- Attachment #1: Type: Text/Plain, Size: 108 bytes --]

On Thursday 31 December 2009 20:28:52 Jun Sun wrote:
> See the attachement.

looks good to me, thanks
-mike

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

Re: [uClinux-dev] [PATCH] error message when FLAT reloc symbol is invalid, v2

[Greg Ungerer]

Hi Jun,

Jun Sun wrote:
> See the attachement.

That looks good. I'll apply to the m68knommu git tree and push to
Linus in the next merge window (for 2.6.34).

Regards
Greg


-- 
------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@snapgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
8 Gardner Close                             FAX:         +61 7 3217 5323
Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com