public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 2/2] option.c: Add 4G W14 stick to blacklist for option_send_setup
@ 2010-01-11  8:35 Gernot Hillier
  0 siblings, 0 replies; only message in thread
From: Gernot Hillier @ 2010-01-11  8:35 UTC (permalink / raw)
  To: Matthias Urlichs, Greg Kroah-Hartman, Oliver Neukum
  Cc: linux-usb, linux-kernel

From: Gernot Hillier <gernot@hillier.de>

The 4G XS Stick W14 seems to not understand RTS/DTR setting in 
option_send_setup causing long timeouts on any open() which 
disturbs a lot of well-known userspace applications like 
minicom or ModemManager.

Therefore, we enable OPTION_BLACKLIST_SENDSETUP blacklisting for it.

Signed-off-by: Gernot Hillier <gernot@hillier.de>

Index: linux-next/drivers/usb/serial/option.c
===================================================================
--- linux-next.orig/drivers/usb/serial/option.c	2010-01-09 10:25:00.000000000 +0100
+++ linux-next/drivers/usb/serial/option.c	2010-01-09 10:25:05.000000000 +0100
@@ -357,6 +357,13 @@ struct option_blacklist_info {
 	option_blacklist_reason_t reason;
 };
 
+static const u8 four_g_w14_no_sendsetup[] = { 0, 1 };
+static const struct option_blacklist_info four_g_w14_blacklist = {
+	.infolen = ARRAY_SIZE(four_g_w14_no_sendsetup),
+	.ifaceinfo = four_g_w14_no_sendsetup,
+	.reason = OPTION_BLACKLIST_SENDSETUP
+};
+
 static struct usb_device_id option_ids[] = {
 	{ USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_COLT) },
 	{ USB_DEVICE(OPTION_VENDOR_ID, OPTION_PRODUCT_RICOLA) },
@@ -657,7 +664,9 @@ static struct usb_device_id option_ids[]
 	{ USB_DEVICE(ALCATEL_VENDOR_ID, ALCATEL_PRODUCT_X060S) },
 	{ USB_DEVICE(AIRPLUS_VENDOR_ID, AIRPLUS_PRODUCT_MCD650) },
 	{ USB_DEVICE(TLAYTECH_VENDOR_ID, TLAYTECH_PRODUCT_TEU800) },
-	{ USB_DEVICE(FOUR_G_SYSTEMS_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14) },
+  	{ USB_DEVICE(FOUR_G_SYSTEMS_VENDOR_ID, FOUR_G_SYSTEMS_PRODUCT_W14),
+  	  .driver_info = (kernel_ulong_t)&four_g_w14_blacklist
+  	},
 	{ USB_DEVICE(HAIER_VENDOR_ID, HAIER_PRODUCT_CE100) },
 	{ } /* Terminating entry */
 };

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-01-11  8:35 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-11  8:35 [PATCH 2/2] option.c: Add 4G W14 stick to blacklist for option_send_setup Gernot Hillier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox