* [staging/hv] why it not follow kernel codingstyle?
@ 2010-01-12 6:29 Figo.zhang
2010-01-12 7:08 ` Figo.zhang
0 siblings, 1 reply; 5+ messages in thread
From: Figo.zhang @ 2010-01-12 6:29 UTC (permalink / raw)
To: gregkh, hjanssen, haiyangz, torvalds; +Cc: linux-kernel
hi all,
i read the driver/staging/hv code, why it will apply into kernel tree
that it not fellow the kernel codingstyle?
it ruin the kernel tree, it had better let the author rewrite it fellow
the "linux kernel CodingStyle".
see Documentation/CodingStyle.
Best,
Figo.zhang
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [staging/hv] why it not follow kernel codingstyle?
2010-01-12 6:29 [staging/hv] why it not follow kernel codingstyle? Figo.zhang
@ 2010-01-12 7:08 ` Figo.zhang
2010-01-12 8:10 ` Ben Nizette
[not found] ` <1293729.429011263564253037.JavaMail.coremail@bj126app34.126.com>
0 siblings, 2 replies; 5+ messages in thread
From: Figo.zhang @ 2010-01-12 7:08 UTC (permalink / raw)
To: gregkh, hjanssen, haiyangz, torvalds, akpm, mingo; +Cc: linux-kernel
hi all,
i read the driver/staging/hv code, why it will apply into kernel tree
that it not follow the kernel codingstyle? it all of "Hungarian
notation".
see Documentation/CodingStyle. In this document,(line 254) it says:
"Encoding the type of a function into the name (so-called Hungarian
notation) is brain damaged".
so it ruin the kernel tree, it had better let the author rewrite it
follow the "linux kernel CodingStyle".
Best,
Figo.zhang
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [staging/hv] why it not follow kernel codingstyle?
2010-01-12 7:08 ` Figo.zhang
@ 2010-01-12 8:10 ` Ben Nizette
[not found] ` <1293729.429011263564253037.JavaMail.coremail@bj126app34.126.com>
1 sibling, 0 replies; 5+ messages in thread
From: Ben Nizette @ 2010-01-12 8:10 UTC (permalink / raw)
To: Figo.zhang
Cc: gregkh, hjanssen, haiyangz, torvalds, akpm, mingo, linux-kernel
On 12/01/2010, at 6:08 PM, Figo.zhang wrote:
> hi all,
>
> i read the driver/staging/hv code, why it will apply into kernel tree that it not follow the kernel codingstyle?
Drivers in the staging/ tree are there because they aren't clean and neat enough for the rest of the kernel tree. By the time it gets promoted to /virt (or where ever) it will have been fixed.
If the state of hv worries you, send patches!
--Ben.
^ permalink raw reply [flat|nested] 5+ messages in thread[parent not found: <1293729.429011263564253037.JavaMail.coremail@bj126app34.126.com>]
* Re: Re: [staging/hv] why it not follow kernel codingstyle?
[not found] ` <1293729.429011263564253037.JavaMail.coremail@bj126app34.126.com>
@ 2010-01-15 15:04 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2010-01-15 15:04 UTC (permalink / raw)
To: figo.zhang
Cc: Ben Nizette, hjanssen, haiyangz, torvalds, akpm, mingo,
linux-kernel
On Fri, Jan 15, 2010 at 10:04:13PM +0800, figo.zhang wrote:
>
> Now it has made the Codingstyle rule, anyone should follow it , right?
Patches are always gladly accepted to fix this stuff up.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
[parent not found: <4650630.501001263607923679.JavaMail.coremail@bj126app13.126.com>]
* Re: [staging/hv] why it not follow kernel codingstyle?
[not found] <4650630.501001263607923679.JavaMail.coremail@bj126app13.126.com>
@ 2010-01-16 2:32 ` Figo.zhang
0 siblings, 0 replies; 5+ messages in thread
From: Figo.zhang @ 2010-01-16 2:32 UTC (permalink / raw)
To: bn, hjanssen, haiyangz; +Cc: gregkh, Linus Torvalds, lkml
> > i am not familiar with the Hyper-V. But happy to see Greg Kroah-Hartman to push
> > the author to motify it follow the Kernel Codingstyle, or apply to merge to main tree
> > until it follow it.
> > Now it has made the Codingstyle rule, anyone should follow it , right?
local variable and function use like "ThisVariableIsATemporaryCounter"
is very very ugly and brain damaged (only Microsoft use it).
Best,
Figo.zhang
Henan University of Science and Technology
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-01-16 2:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-12 6:29 [staging/hv] why it not follow kernel codingstyle? Figo.zhang
2010-01-12 7:08 ` Figo.zhang
2010-01-12 8:10 ` Ben Nizette
[not found] ` <1293729.429011263564253037.JavaMail.coremail@bj126app34.126.com>
2010-01-15 15:04 ` Greg KH
[not found] <4650630.501001263607923679.JavaMail.coremail@bj126app13.126.com>
2010-01-16 2:32 ` Figo.zhang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox