From: Eric Dumazet <eric.dumazet@gmail.com>
To: James Kosin <JKosin@intcomgrp.com>
Cc: linux-kernel@vger.kernel.org, Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: arm: Optimization for ethernet MAC handling at91_ether.c
Date: Tue, 12 Jan 2010 20:24:43 +0100 [thread overview]
Message-ID: <4B4CCC7B.8040609@gmail.com> (raw)
In-Reply-To: <3DBBD805E3BA064A87F551C0E8BD36740289741C@MAILSRV.intcomgrp.com>
Le 12/01/2010 20:03, James Kosin a écrit :
>
> Scratch that. The interrupt doesn't queue up or send another packet directly. So, it wouldn't help on performance here. But, may in other implementations that queue/transmit packets in the ISR. At least in the case where the transmitter is limited to one.
>
It could, at least on SMP. tx completion wakes a blocked sender, while
this cpu continue with RX handling (possibly expensive)
But even on UP, doing tx completion before rx handling allows
a better reuse of skb just freed (and partly present in cpu cache, if available).
Start of IRQ
1) tx completion
-> free a skb
2) rx handling:
-> allocate an skb, kmalloc() reuses previous one, still in cpu cache.
End of IRQ
next prev parent reply other threads:[~2010-01-12 19:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-12 15:39 arm: Optimization for ethernet MAC handling at91_ether.c James Kosin
2010-01-12 16:35 ` Eric Dumazet
2010-01-12 17:51 ` James Kosin
2010-01-12 18:08 ` Eric Dumazet
2010-01-12 18:42 ` James Kosin
2010-01-12 19:03 ` James Kosin
2010-01-12 19:24 ` Eric Dumazet [this message]
2010-01-12 19:39 ` James Kosin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4CCC7B.8040609@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=JKosin@intcomgrp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox