Re: [PATCH] regulator: Add 'start-up time' to fixed voltage regulators

[Adrian Hunter <adrian.hunter@nokia.com>]

Mark Brown wrote:
> On Wed, Jan 13, 2010 at 01:58:26PM +0200, Adrian Hunter wrote:
> 
>> Add a field to specify a delay for the start-up time of
>> a fixed voltage regulator.
> 
>> Signed-off-by: Adrian Hunter <adrian.hunter@nokia.com>
> 
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> 
> but...
> 
>> #include <linux/regulator/driver.h>
>> #include <linux/regulator/fixed.h>
>> #include <linux/gpio.h>
>> +#include <linux/delay.h>
> 
> I think your MUA may have eaten the patch - it looks like the leading
> spaces got stripped which is liable to confuse things.
> 

Are you sure?  Looks fines to me.

>> --- a/include/linux/regulator/fixed.h
>> +++ b/include/linux/regulator/fixed.h
>> @@ -25,6 +25,7 @@ struct regulator_init_data;
>>  * @microvolts:		Output voltage of regulator
>>  * @gpio:		GPIO to use for enable control
>>  * 			set to -EINVAL if not used
>> + * @delay:		Start-up time in microseconds
> 
> startup_delay?  Just in case we think of another delay, though I'm
> struggling to think of one right now so I'm not too worried.
> 

I am too lazy to change it unless there is something else too ;-)