public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* tracing: Multi definition of TRACE_INCLUDE_FILE
@ 2010-01-06  7:40 Wenji Huang
  2010-01-14  2:41 ` Steven Rostedt
  0 siblings, 1 reply; 3+ messages in thread
From: Wenji Huang @ 2010-01-06  7:40 UTC (permalink / raw)
  To: LKML; +Cc: Ingo Molnar, Frederic Weisbecker

Hi,

There are multi definition of TRACE_INCLUDE_FILE on
include/trace/events/{syscalls, kvm}.h
It will result in compilation error when some
out-of-tree tools like Systemtap processes kernel
tracepoints in a way to put header files into module.

Regards,
Wenji

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: tracing: Multi definition of TRACE_INCLUDE_FILE
  2010-01-06  7:40 tracing: Multi definition of TRACE_INCLUDE_FILE Wenji Huang
@ 2010-01-14  2:41 ` Steven Rostedt
  2010-01-14  2:46   ` Wenji Huang
  0 siblings, 1 reply; 3+ messages in thread
From: Steven Rostedt @ 2010-01-14  2:41 UTC (permalink / raw)
  To: Wenji Huang; +Cc: LKML, Ingo Molnar, Frederic Weisbecker

On Wed, Jan 06, 2010 at 03:40:40PM +0800, Wenji Huang wrote:
> Hi,
> 
> There are multi definition of TRACE_INCLUDE_FILE on
> include/trace/events/{syscalls, kvm}.h
> It will result in compilation error when some
> out-of-tree tools like Systemtap processes kernel
> tracepoints in a way to put header files into module.
> 

Does the following patch fix your issues?

-- Steve


diff --git a/include/trace/events/kvm.h b/include/trace/events/kvm.h
index dbe1084..532d658 100644
--- a/include/trace/events/kvm.h
+++ b/include/trace/events/kvm.h
@@ -4,6 +4,7 @@
 #include <linux/tracepoint.h>
 
 #undef TRACE_SYSTEM
+#undef TRACE_INCLUDE_FILE
 #define TRACE_SYSTEM kvm
 #define TRACE_INCLUDE_FILE kvm
 
diff --git a/include/trace/events/syscalls.h b/include/trace/events/syscalls.h
index fb726ac..52290bb 100644
--- a/include/trace/events/syscalls.h
+++ b/include/trace/events/syscalls.h
@@ -1,4 +1,5 @@
 #undef TRACE_SYSTEM
+#undef TRACE_INCLUDE_FILE
 #define TRACE_SYSTEM raw_syscalls
 #define TRACE_INCLUDE_FILE syscalls
 

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: tracing: Multi definition of TRACE_INCLUDE_FILE
  2010-01-14  2:41 ` Steven Rostedt
@ 2010-01-14  2:46   ` Wenji Huang
  0 siblings, 0 replies; 3+ messages in thread
From: Wenji Huang @ 2010-01-14  2:46 UTC (permalink / raw)
  To: Steven Rostedt; +Cc: LKML, Ingo Molnar, Frederic Weisbecker

Hi Steven,

Steven Rostedt wrote:
> On Wed, Jan 06, 2010 at 03:40:40PM +0800, Wenji Huang wrote:
>> Hi,
>>
>> There are multi definition of TRACE_INCLUDE_FILE on
>> include/trace/events/{syscalls, kvm}.h
>> It will result in compilation error when some
>> out-of-tree tools like Systemtap processes kernel
>> tracepoints in a way to put header files into module.
>>
> 
> Does the following patch fix your issues?
> 

Yes, that could be.

Thanks,
wenji

> -- Steve
> 
> 
> diff --git a/include/trace/events/kvm.h b/include/trace/events/kvm.h
> index dbe1084..532d658 100644
> --- a/include/trace/events/kvm.h
> +++ b/include/trace/events/kvm.h
> @@ -4,6 +4,7 @@
>  #include <linux/tracepoint.h>
>  
>  #undef TRACE_SYSTEM
> +#undef TRACE_INCLUDE_FILE
>  #define TRACE_SYSTEM kvm
>  #define TRACE_INCLUDE_FILE kvm
>  
> diff --git a/include/trace/events/syscalls.h b/include/trace/events/syscalls.h
> index fb726ac..52290bb 100644
> --- a/include/trace/events/syscalls.h
> +++ b/include/trace/events/syscalls.h
> @@ -1,4 +1,5 @@
>  #undef TRACE_SYSTEM
> +#undef TRACE_INCLUDE_FILE
>  #define TRACE_SYSTEM raw_syscalls
>  #define TRACE_INCLUDE_FILE syscalls
>  


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-01-14  2:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-06  7:40 tracing: Multi definition of TRACE_INCLUDE_FILE Wenji Huang
2010-01-14  2:41 ` Steven Rostedt
2010-01-14  2:46   ` Wenji Huang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox