public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Li Zefan <lizf@cn.fujitsu.com>
To: Masami Hiramatsu <mhiramat@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf probe: Fix build failure
Date: Thu, 14 Jan 2010 13:23:32 +0800	[thread overview]
Message-ID: <4B4EAA54.9000109@cn.fujitsu.com> (raw)
In-Reply-To: <4B4EA2BC.9000307@redhat.com>

Masami Hiramatsu wrote:
> Hi,
> 
> Thank you, the patch code looks good to me.
> 
> Li Zefan wrote:
>> builtin-probe.c:121: error: 'opt_show_lines' defined but not used
> 
> Please add some comment for explanation, like:
> 
> This build error occurs when compiling perf-tools without dwarf
> support (no libdwarf).
> 

But as simple as this patch, the code itself has explained
the cause of this compile error.


  reply	other threads:[~2010-01-14  5:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-14  3:03 [PATCH] perf probe: Fix build failure Li Zefan
2010-01-14  4:51 ` Masami Hiramatsu
2010-01-14  5:23   ` Li Zefan [this message]
2010-01-14  6:20     ` Masami Hiramatsu
2010-01-14  6:30       ` Li Zefan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B4EAA54.9000109@cn.fujitsu.com \
    --to=lizf@cn.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhiramat@redhat.com \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox