From: "H. Peter Anvin" <hpa@zytor.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: x86: clean up rwsem type system
Date: Wed, 13 Jan 2010 23:03:01 -0800 [thread overview]
Message-ID: <4B4EC1A5.4010701@zytor.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1001121810410.17145@localhost.localdomain>
On 01/12/2010 06:16 PM, Linus Torvalds wrote:
>
> In case anybody wants to test, the final piece is appended.
>
> Again, note the 32767-thread limit here. So this really does need that
> whole "make rwsem_count_t be 64-bit and fix the BIAS values to match"
> extension on top of it, but that is conceptually a totally independent
> issue.
>
> NOT TESTED! The original patch that this all was based on were tested by
> KAMEZAWA Hiroyuki, but maybe I screwed up something when I created the
> cleaned-up series, so caveat emptor..
>
> Also note that it _may_ be a good idea to mark some more registers
> clobbered on x86-64 in the inline asms instead of saving/restoring them.
> They are inline functions, but they are only used in places where there
> are not a lot of live registers _anyway_, so doing for example the
> clobbers of %r8-%r11 in the asm wouldn't make the fast-path code any
> worse, and would make the slow-path code smaller.
>
Hi Linus,
I have put these into a separate topic branch in the tip tree, which
should get them some test coverage. I will look at 64-bit counters to
support 2^31 threads hopefully later this week, unless you prefer to do
it yourself.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2010-01-14 7:03 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-13 0:21 x86-32: clean up rwsem inline asm statements Linus Torvalds
2010-01-13 0:45 ` Andreas Schwab
2010-01-13 1:26 ` Linus Torvalds
2010-01-13 0:48 ` H. Peter Anvin
2010-01-13 0:59 ` Linus Torvalds
2010-01-13 1:24 ` x86: avoid read-cycle on down_read_trylock Linus Torvalds
2010-01-13 1:57 ` x86: clean up rwsem type system Linus Torvalds
2010-01-13 2:16 ` Linus Torvalds
2010-01-14 7:03 ` H. Peter Anvin [this message]
2010-01-17 6:05 ` Ingo Molnar
2010-01-17 18:24 ` Linus Torvalds
2010-01-21 17:14 ` Ingo Molnar
2010-01-13 5:03 ` [tip:x86/asm] x86-32: clean up rwsem inline asm statements tip-bot for Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B4EC1A5.4010701@zytor.com \
--to=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox