Re: [PATCH] tcp: harmonize tcp_vx_rcv header length assumptions

William Allen Simpson
2010-01-12T17:11:39Z

Eric Dumazet wrote:
> Seems fine, but :
>
> 1) What means the "Transformed ?" you wrote several times ?
>
The only reason that I've been able to figure out for having the
skb->len test in those places is the preceding xfrm4_policy_check()
or xfrm6_policy_check() must be able to shrink the skb->len?

When I did the original transform stuff in other code circa 1995, I'd
envisioned IP length or link layer (PPP) length shrinking (removing
padding after block ciphers) -- and apparently this implementation
extended that concept to transport layer, too.

Personally, I'd prefer that a single test be placed in the appropriate
spot in the xfrm* functions, instead. Anybody know where?