Re: [PATCH v4] tcp: harmonize tcp_vx_rcv header length assumptions

William Allen Simpson
2010-01-13T21:13:51Z

I did today's tests on tcp_ipv4, but part of this harmonization is to
make v4 and v6 match up better. As I was examining line by line, one of
the things that leaps out is that ipv4 has nf_reset(skb):

tcp_ipv4:
if (!xfrm4_policy_check(sk, XFRM_POLICY_IN, skb))
goto discard_and_relse;
nf_reset(skb);

if (sk_filter(sk, skb))
goto discard_and_relse;

tcp_ipv6:
if (!xfrm6_policy_check(sk, XFRM_POLICY_IN, skb))
goto discard_and_relse;

if (sk_filter(sk, skb))
goto discard_and_relse;

Does anybody know why? Should ipv6 have it? Or at least a comment
explaining the reasoning for the omission?